FIX: Enable field plotting with discrete sweep #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow sweep.name as a setup. - pass variations as optional keywords - "SaveRadFields" default is False in setup_templates.py - pass props to SweepHFSS()
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
For more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5683 +/- ##
==========================================
- Coverage 85.22% 85.22% -0.01%
==========================================
Files 156 156
Lines 61216 61258 +42
==========================================
+ Hits 52172 52207 +35
- Misses 9044 9051 +7 |
- Fix loop syntax. - Add correct logger syntax.
For more information, see https://pre-commit.ci
- Report type for far_field should be "Radiation Pattern" - Fix error in FarField class when assigning variations.
…license-issues' into fix_HFSS_linear_step_sweep
- Add test project file Potter_Horn_242.aedtz - Update unit test to check field plotting for discrete sweep. - Allow sweep name to be passed to `create_report_from_configuration()`
- Revert setup_templates.py - Correct docstring error in hfss.py
- update unit test for discrete frequency sweep in HFSS.
For more information, see https://pre-commit.ci
- update Q3D Setup behavior to be consistent with HFSS.
… fix_HFSS_linear_step_sweep
For more information, see https://pre-commit.ci
- Update _get_setup_from_sweep_name to avoid throwing an error.
… fix_HFSS_linear_step_sweep
- Use last adaptive as default sweep when nothing is passed for field plotting.
# Conflicts: # src/ansys/aedt/core/modules/solve_setup.py # tests/system/general/test_12_PostProcessing.py
Samuelopez-ansys
previously approved these changes
Feb 7, 2025
Allow props to be passed to the HFSS sweep setup.
… fix_HFSS_linear_step_sweep
For more information, see https://pre-commit.ci
This was
linked to
issues
Feb 7, 2025
Closed
Samuelopez-ansys
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable plotting of solution and far-field data from a single frequency point
in a discrete sweep.
Issue linked
#5682
#5630
Checklist