FEAT: Identify coupling 5649

[amichel0205]

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

• I have tested my changes locally.
• I have added necessary documentation or updated existing documentation.
• I have followed the coding style guidelines of this project.
• I have added appropriate tests (unit, integration, system).
• I have reviewed my changes before submitting this pull request.
• I have linked the issue or issues that are solved by the PR if any.
• I have agreed with the Contributor License Agreement (CLA).

[ansys-reviewer-bot]

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

[codecov]

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.98%. Comparing base (be8f391) to head (3785fbb).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5659      +/-   ##
==========================================
- Coverage   85.21%   79.98%   -5.23%     
==========================================
  Files         156      156              
  Lines       61070    61106      +36     
==========================================
- Hits        52038    48876    -3162     
- Misses       9032    12230    +3198     

[hui-zhou-a]

@amichel0205 please use a valid s-parameter for testing.

[Samuelopez-ansys]

Hi @amichel0205 ,

I think the argument log_file_name should be the last one and not the first one, because it is only used when you want to save it.

In addition, you should change the name, to output_file, we are trying to make consisten name of variables in all PyAEDT, the methods, the description could be something like:

Output file path to save .... . If None no file is saved.

The same for start_at_frequency, should be start_frequency keeping consistency.

[Samuelopez-ansys]

LGTM

[SMoraisAnsys]

I left some refactoring proposition.

[hui-zhou-a]

LGTM