FEAT: Add distributed filters substrate #5646
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sys/pyaedt into FEAT__Add_distributed_filters # Conflicts: # src/ansys/aedt/core/filtersolutions.py
For more information, see https://pre-commit.ci
…sys/pyaedt into FEAT__Add_distributed_filters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
github-actions
bot
added
testing
ramin4667
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5646 +/- ##
==========================================
- Coverage 85.24% 85.19% -0.06%
==========================================
Files 154 156 +2
Lines 60767 61070 +303
==========================================
+ Hits 51802 52029 +227
- Misses 8965 9041 +76 |
There was a problem hiding this comment.
Hi @ramin4667, thanks for the contribution !
Are these changes only available starting with AEDT 2025.2 ? If that's the case, would you consider having a look at #5631 where there is a decorator you might want to leverage (if it gets merged)
|
@SMoraisAnsys Thanks for informing me. I have added a version check for older versions that are not supported. |
myoung301
reviewed
Jan 21, 2025
|
|
||
| @property | ||
| def tuning_type_1(self) -> bool: | ||
| """Flag indicating if both legs of the outer hairpins are set for tuning in ``Haripin`` |
There was a problem hiding this comment.
Suggested change
| """Flag indicating if both legs of the outer hairpins are set for tuning in ``Haripin`` | |
| """Flag indicating if both legs of the outer hairpins are set for tuning in ``Hairpin`` |
…hub.com/ansys/pyaedt into FEAT__Add_distributed_filters_substrate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds attributes of the substrate page of distributed filters to the FilterSolutions API.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist