Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: Test architecture and CICD #5351

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Conversation

SMoraisAnsys
Copy link
Collaborator

Follow up of #5313

Changes:

  • Split tests between system and unit tests
  • Update CICD to use add unit tests job; use common pytest options (impact: durations is set to 25 everywhere)
  • Update configuration related to pytest / testing to match tests folder architecture
  • Remove _unittest_ironpython folder

Note: the coverage of the tests is no longer performed by default when running the tests of pyaedt.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to testing labels Oct 28, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (6462a41) to head (fc98d98).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5351      +/-   ##
==========================================
+ Coverage   84.32%   84.34%   +0.01%     
==========================================
  Files         140      140              
  Lines       58460    58460              
==========================================
+ Hits        49298    49307       +9     
+ Misses       9162     9153       -9     

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@SMoraisAnsys SMoraisAnsys merged commit dafbb23 into main Oct 31, 2024
39 of 41 checks passed
@SMoraisAnsys SMoraisAnsys deleted the refact/tests-architecture-2 branch October 31, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants