Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: improving documentation of add mesh link #5341

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

anur7
Copy link
Contributor

@anur7 anur7 commented Oct 24, 2024

No description provided.

@anur7 anur7 added the documentation Improvements or additions to documentation label Oct 24, 2024
@anur7 anur7 self-assigned this Oct 24, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Oct 24, 2024 that may be closed by this pull request
@anur7 anur7 marked this pull request as ready for review October 24, 2024 18:49
Copy link

@SebastienMorais SebastienMorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the _unittest/.cov/xml file from the PR

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.33%. Comparing base (b3fd3cb) to head (dcdc7a8).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5341      +/-   ##
==========================================
+ Coverage   83.01%   84.33%   +1.31%     
==========================================
  Files         140      140              
  Lines       58460    58460              
==========================================
+ Hits        48532    49300     +768     
+ Misses       9928     9160     -768     

@MaxJPRey MaxJPRey changed the title DOC: improving documentation of add mesh link DOCS: improving documentation of add mesh link Oct 25, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated from another accound, please remove the .cov folder

src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
@gmalinve
Copy link
Contributor

@anur7 please update the branch and reply to the discussion.

@anur7 anur7 requested a review from gmalinve October 29, 2024 13:11
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
@anur7 anur7 requested a review from gmalinve October 29, 2024 13:29
@anur7 anur7 merged commit 25c9ca1 into main Oct 30, 2024
41 checks passed
@anur7 anur7 deleted the doc/Improving-documentation-of-add-mesh-link branch October 30, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving docstring of add_mesh_link method
4 participants