FIX: Fix hardcoded APPDATA in extension manager #5300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samuelopez-ansys
requested review from
maxcapodi78,
amichel0205 and
SMoraisAnsys
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5300 +/- ##
==========================================
+ Coverage 80.36% 84.24% +3.88%
==========================================
Files 140 140
Lines 58565 58565
==========================================
+ Hits 47065 49338 +2273
+ Misses 11500 9227 -2273 |
There was a problem hiding this comment.
Thanks for this changes, they make total sense !
I proposed some minor changes to remove dead code and avoid shell injection.
Also, following #5288, we might need to add a disclaimer here.
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
|
@Samuelopez-ansys Any news on what doesn't allow us to use subprocess ? |
SMoraisAnsys
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolkit venv is still in APPDATA or HOME for Linux fixed for now
Close #5294