-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Fix hardcoded APPDATA in extension manager #5300
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5300 +/- ##
==========================================
+ Coverage 80.36% 84.24% +3.88%
==========================================
Files 140 140
Lines 58565 58565
==========================================
+ Hits 47065 49338 +2273
+ Misses 11500 9227 -2273 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this changes, they make total sense !
I proposed some minor changes to remove dead code and avoid shell injection.
Also, following #5288, we might need to add a disclaimer here.
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
@Samuelopez-ansys Any news on what doesn't allow us to use subprocess ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I was finally able to test running the script on Linux !
Toolkit venv is still in APPDATA or HOME for Linux fixed for now
Close #5294