Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: added check in desktop_release #4952

Merged
merged 1 commit into from
Jul 25, 2024
Merged

FIX: added check in desktop_release #4952

merged 1 commit into from
Jul 25, 2024

Conversation

maxcapodi78
Copy link
Collaborator

Was causing an error in dotnet approach

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jul 25, 2024
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (28563d9) to head (93f9769).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4952      +/-   ##
==========================================
- Coverage   83.37%   83.36%   -0.01%     
==========================================
  Files         120      120              
  Lines       54478    54479       +1     
==========================================
- Hits        45423    45419       -4     
- Misses       9055     9060       +5     

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) July 25, 2024 09:49
@maxcapodi78 maxcapodi78 merged commit 139bd47 into main Jul 25, 2024
45 checks passed
@maxcapodi78 maxcapodi78 deleted the fix_grpc_plugin branch July 25, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants