Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: added import and export method to Rmxprt class #4951

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

maxcapodi78
Copy link
Collaborator

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the examples Anything related to the examples label Jul 25, 2024
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.43%. Comparing base (28563d9) to head (7124698).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4951      +/-   ##
==========================================
+ Coverage   83.37%   83.43%   +0.05%     
==========================================
  Files         120      120              
  Lines       54478    54513      +35     
==========================================
+ Hits        45423    45483      +60     
+ Misses       9055     9030      -25     

Alberto-DM
Alberto-DM previously approved these changes Jul 25, 2024
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made two comments for readability of the code. Otherwise LGTM.

pyaedt/rmxprt.py Show resolved Hide resolved
pyaedt/rmxprt.py Show resolved Hide resolved
Co-authored-by: Alberto Di Maria <[email protected]>
@Alberto-DM Alberto-DM self-requested a review July 25, 2024 09:21
Copy link
Contributor

@Alberto-DM Alberto-DM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 merged commit 2866a99 into main Jul 25, 2024
46 checks passed
@maxcapodi78 maxcapodi78 deleted the added_configuration_rmxprt branch July 25, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Anything related to the examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants