Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Dipole Example #311

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

FIX: Dipole Example #311

wants to merge 19 commits into from

Conversation

Devin-Crawford
Copy link
Collaborator

Pull Request Template

Description

Checklist

Please complete the following checklist before submitting your pull request:

  • I have followed the example template and guide lines to add/update an example.
  • I have tested the example locally and verified that it is working with the latest version of AEDT.
  • I have verified that these changes to the best of my knowledge do not introduce any security vulnerabilities.

- Fix errors that led to an invalid project.
- Update to match template.
- Allow discrete sweep for dipole.py
- Add interpolating and discrete sweeps
- Match template format.
- Fix numerous errors in plotting and rendering.
- Allow multiple frequencies for adaptive refinement.
- Expand explanation of functions used in this examle.
- Add images for dipole example.
- Add images for dipole example.
- Re-run in 25R1 and remove relative CS
  parts which did not work properly.
# Conflicts:
#	examples/high_frequency/antenna/dipole.py
@Devin-Crawford Devin-Crawford changed the title Fix/high frequency/antenna FIX: Dipole Example Feb 27, 2025
@github-actions github-actions bot added the bug Something isn't working label Feb 27, 2025
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few minor changes propositions

Devin-Crawford and others added 4 commits February 28, 2025 06:26
@Devin-Crawford Devin-Crawford enabled auto-merge (squash) February 28, 2025 15:08
Copy link
Collaborator Author

@Devin-Crawford Devin-Crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback. Changes have been implemented.

@Devin-Crawford
Copy link
Collaborator Author

@SMoraisAnsys : The CI/CD is failing but seems unrelated to any of the changes in this PR. There's an error about the template.py which was not changed in this PR. Can you help?

@Samuelopez-ansys
Copy link
Member

@Devin-Crawford The template should not break anything because it is skipped https://github.com/ansys/pyaedt-examples/blob/main/doc/source/conf.py#L256

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants