-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Dipole Example #311
base: main
Are you sure you want to change the base?
FIX: Dipole Example #311
Conversation
- Fix errors that led to an invalid project. - Update to match template.
- Allow discrete sweep for dipole.py - Add interpolating and discrete sweeps - Match template format.
- Fix numerous errors in plotting and rendering. - Allow multiple frequencies for adaptive refinement. - Expand explanation of functions used in this examle.
- Add images for dipole example.
- Add images for dipole example.
- Re-run in 25R1 and remove relative CS parts which did not work properly.
# Conflicts: # examples/high_frequency/antenna/dipole.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few minor changes propositions
- Minor syntax updates per suggestions.
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
Co-authored-by: Sébastien Morais <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Changes have been implemented.
@SMoraisAnsys : The CI/CD is failing but seems unrelated to any of the changes in this PR. There's an error about the |
@Devin-Crawford The template should not break anything because it is skipped https://github.com/ansys/pyaedt-examples/blob/main/doc/source/conf.py#L256 |
- Resolve #315
- Ignore this file in CI/CD due to incompatibility with Linux. - Update to match template.
Pull Request Template
Description
Checklist
Please complete the following checklist before submitting your pull request: