-
Notifications
You must be signed in to change notification settings - Fork 7
chore: pin python package dependencies #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for taking care of that @SMoraisAnsys |
jorgepiloto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some questions. The only thing I am concerned is that this causes some issues when using the actions since we are now imposing a specific version for some packages.
I'm not sure we'll end up with any issue tbh. Guess it's a good candidate to leverage the pre release feature ? :D |
|
I've updated the code of the |
|
@jorgepiloto @moe-ad It's been more than a month that this PR is open, should it be closed ? If not I can refresh my mind on its content cause I've lost track of the associated changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing before merging this is to update the dependabot.yml so that it is aware about these new requirements.txt files.
Let's discuss about those changes during tomorrow's meeting to see if we are missing something. |
|
Following today's discussion, I'm switching to draft mode. Here are the available options to be explored (by order of personal taste):
|
Changes to address #985.