Skip to content

Conversation

@rborsaru-ansys
Copy link

Initial commit for this branch

@rborsaru-ansys rborsaru-ansys requested a review from a team as a code owner June 12, 2025 09:14
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added ci Pipelines maintenance related fix Pull requests related to resolving problems or errors labels Jun 12, 2025
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left one suggestion for this, @rborsaru-ansys. Knowing that the build library accepts now a working directory, maybe we can revisit the tests job in this file.

@SMoraisAnsys
Copy link
Contributor

Hi @rborsaru-ansys, I don't know why this PR is open but if you want to test a change to any action in this repo, could you simply update your CICD workflow and reference this branch, e.g. ansys/actions@v10 -> ansys/actions@fix/unify-artifacts-file-names, instead of opening a PR ?

@rborsaru-ansys
Copy link
Author

Hi @jorgepiloto and @SMoraisAnsys ,
Thank you for your comments.
Let me answer your comments.
I am trying to resolve this issue from milestone 10.1 - Unify artifacts file names.
I have created a branch and now i am using this pr in order to trigger the gh action build. I am using a reference to the action on my branch, but was not sure how to trigger the pipeline without raising a pr.
I have added the build-library to this pipeline so i can test my solution.
I have used working-folder to give the path to the test library that is set for the actions repository.
Have used .ci/ansys-actions first but that did not work. After looking through some other repos that are using this action tried the .ci folder as well, but that failed as well, as expected.
Not sure what should i be using in my branch to be able to build the test ansys-actions-core library.

Thank you.

@rborsaru-ansys rborsaru-ansys changed the title Creating new branch to test the wheels with underscores feat: generate wheels package with underscores instead of dashes Jun 16, 2025
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, @rborsaru-ansys. Thanks for fixing this.

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @rborsaru-ansys

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raised my concerns in #681 - but this implementation is great @rborsaru-ansys ! Thanks a lot!

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to avoid this PR to be merged as long as the discussion in #681 is not over.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just left one minor comment.

python-version: ${{ matrix.python }}
working-directory: .ci/ansys-actions

package-library:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we could reuse this in other parts of the code before uploading the dist to the PyPI Test. We can try to do this in a separate pull-request.

@rborsaru-ansys
Copy link
Author

I have fixed the build-library action code to properly use the working-directory. Now my job only fails because of the final tests and that is because of the name of the library.
I will add the dash2underscore changes to SBOM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related fix Pull requests related to resolving problems or errors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants