-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add breaking change section #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
|
Hmmm... Weren't breaking changes done as Can't access easily the conventional commits site (security issue apparently) but see https://gist.github.com/qoomon/5dfcdf8eec66a051ecd85625518cfd13#breaking-changes-indicator EDIT - just saw that you are handling this case too... I overlooked it, sorry! |
|
What's the status here @SMoraisAnsys? I think @jorgepiloto is planning on doing the release tomorrow or Wednesday latest. |
Adds checking for breaking change in the PR title and body. On repos following conventionnal commits, this will greatly help:
I think that this could be used as a metric to know whether a repo is ready to move to version
1.0.0Close #722