Open
Conversation
moe-ad
changed the title
moe-ad
requested review from
Revathyvenugopal162,
SMoraisAnsys,
germa89 and
jorgepiloto
Contributor
|
I would keep the minimum value to 3.10. @moe-ad Could you also have a look into https://github.com/stefan6419846/pip-licenses-lib and https://github.com/stefan6419846/pip-licenses-cli ? They seem to be a solution that got created while, or even before that, the original |
dipinknair
reviewed
Feb 23, 2026
| run: | | ||
| ${ACTIVATE_VENV} | ||
| $INSTALL_COMMAND external/pip-licenses | ||
| $INSTALL_COMMAND -U pip |
Contributor
There was a problem hiding this comment.
I think we can remove pip upgrade here since its already done at line 260
dipinknair
reviewed
Feb 23, 2026
| ${ACTIVATE_VENV} | ||
| $INSTALL_COMMAND external/pip-licenses | ||
| $INSTALL_COMMAND -U pip | ||
| $INSTALL_COMMAND pip-licenses |
Contributor
There was a problem hiding this comment.
Should we pin the version
$INSTALL_COMMAND "pip-licenses>=5.0" ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1047.
I ran tests in the Metapackage against Python 3.9 through 3.13 and the tests pass (see ansys/pyansys#1205).
Since
pip-licensesofficially supports Python 3.9, should we still be enforcing 3.10 as the minimum Python inansys/check-licensesor it is ok to stop doing that like I have already done?@RobPasMue @SMoraisAnsys @jorgepiloto