Conversation
moe-ad
force-pushed
the
feat/tox-implementation
branch
from
aa6ce23 to
2ac902a
Compare
github-actions
bot
added
the
enhancement
moe-ad
requested review from
AlejandroFernandezLuces,
Revathyvenugopal162,
SMoraisAnsys and
dipinknair
Contributor
SMoraisAnsys
left a comment
SMoraisAnsys
left a comment
There was a problem hiding this comment.
That would be very valuable @moe-ad, thanks for this !
I added some minor comments.
jorgepiloto
requested changes
Feb 23, 2026
Member
jorgepiloto
left a comment
jorgepiloto
left a comment
There was a problem hiding this comment.
Awesome and needed pull. Just left some requests on my side.
MaxJPRey
reviewed
Feb 23, 2026
MaxJPRey
reviewed
Feb 23, 2026
|
|
||
| new_content, count = re.subn(old_pattern, new_replacement, content) | ||
|
|
||
| if count > 0: |
Contributor
There was a problem hiding this comment.
Maybe we could write a message if count == 0 to understand the absence of update.
Only in the case of the dry-run to not be too noisy.
Not mandatory as it could become cumbersome, but could help to debug and test.
Contributor
Author
There was a problem hiding this comment.
I have added more debugging related code in 57f1327. Let me know what you think.
Contributor
Author
|
@jorgepiloto @SMoraisAnsys @MaxJPRey thanks for your reviews. Can you give this a look again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #815. Check the issue for context that might be missing here.
Important things to note
python-utils/test_versions.pywas also included.