Skip to content

Conversation

@moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Nov 10, 2025

Closes #843.

@SMoraisAnsys @RobPasMue.
Do you have some ideas about how point 2 of the issue can be handled automatically? Seems like a manual task to me.

@moe-ad moe-ad self-assigned this Nov 10, 2025
@github-actions github-actions bot added enhancement General improvements to existing features ci Pipelines maintenance related labels Nov 10, 2025
@moe-ad moe-ad marked this pull request as ready for review November 11, 2025 08:44
@moe-ad moe-ad requested a review from a team as a code owner November 11, 2025 08:44
@moe-ad
Copy link
Contributor Author

moe-ad commented Nov 11, 2025

FYI I left the failing workflow as is so reviewers can see how the action currently works. I will fix it once this has been approved for merging.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the logic seems fine - I'm just concerned about what to do if a 3rd party action is missing. I believe we should open a PR automatically from this workflow

@moe-ad
Copy link
Contributor Author

moe-ad commented Nov 11, 2025

Overall the logic seems fine - I'm just concerned about what to do if a 3rd party action is missing. I believe we should open a PR automatically from this workflow

Thanks for the suggestions Roberto. I must have misunderstood #843. I didn't know this was to be offered as a reusable action for other repos to consume. I simply implemented it as a workflow for this repo. I will fix that.

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @moe-ad, I left a minor comment.

Agreeing with @RobPasMue comments. We could also add the job to the PR workflow as it would notify someone of that lack in the PR changes but it will often run for nothing since we don't add third party actions very often.

@RobPasMue
Copy link
Member

I didn't know this was to be offered as a reusable action for other repos to consume.

I am not saying it should be consumed by other repos, not at all in fact.

What I am suggesting is that the same workflow you implemented should also open a PR on the ansys/actions repo and update the dependabot.yml file to include the missing actions. We shouldn't just get informed that some actions are missing. We should remediate the problem

@moe-ad
Copy link
Contributor Author

moe-ad commented Nov 12, 2025

I didn't know this was to be offered as a reusable action for other repos to consume.

I am not saying it should be consumed by other repos, not at all in fact.

What I am suggesting is that the same workflow you implemented should also open a PR on the ansys/actions repo and update the dependabot.yml file to include the missing actions. We shouldn't just get informed that some actions are missing. We should remediate the problem

@RobPasMue @SMoraisAnsys The challenge with opening a PR is related to my opening question on this PR. The problem of classifying an action under a meaningful group seems seems like a manual task. I guess an issue should be opened instead?

@RobPasMue
Copy link
Member

RobPasMue commented Nov 13, 2025

@RobPasMue @SMoraisAnsys The challenge with opening a PR is related to my opening question on this PR. The problem of classifying an action under a meaningful group seems seems like a manual task. I guess an issue should be opened instead?

Since this part is not working:

# Missed non ansys actions that should by assigned to a group
must-be-assigned-actions:
patterns:
- "*"
exclude-patterns:
- "ansys/actions*"

I'd recommend removing the asterisk at large and adding the individual actions found to this group. We can move them manually later if desired

@moe-ad moe-ad force-pushed the feat/workflow-to-check-missing-dependabot-configuration branch from f7bac45 to 2cfcf83 Compare November 13, 2025 12:57
@moe-ad
Copy link
Contributor Author

moe-ad commented Nov 13, 2025

Test: #1057
N.B: The test PR includes dependabot_coverage.yml since that doesn't exist yet on main. Once we merge this, that shouldn't happen.

@SMoraisAnsys I think we should avoid adding this to the PR workflow. I have added a workflow_dispatch trigger instead if we need to run this before the scheduled time. I will also leverage that to test the changes one final time upon merging (I intentionally didn't update dependabot.yml with peter-evans/find-comment, pyvista/setup-headless-display-action, vimtor/action-zip yet so those can be added via the final test).

@RobPasMue
Copy link
Member

I would run this on a scheduled basis as well @moe-ad - not only on workflow dispatch

Co-authored-by: Roberto Pastor Muela <[email protected]>
@jorgepiloto
Copy link
Member

What about moving this to the ci_cd_night.yml? Just to reduce the number of workflow files to pr, night, and release`.

@RobPasMue
Copy link
Member

What about moving this to the ci_cd_night.yml? Just to reduce the number of workflow files to pr, night, and release`.

Works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related enhancement General improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add workflow to check nothing is missing with respect to dependabot's configuration

6 participants