-
Notifications
You must be signed in to change notification settings - Fork 7
ci: add job to check dependabot configuration coverage #1056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: add job to check dependabot configuration coverage #1056
Conversation
|
FYI I left the failing workflow as is so reviewers can see how the action currently works. I will fix it once this has been approved for merging. |
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the logic seems fine - I'm just concerned about what to do if a 3rd party action is missing. I believe we should open a PR automatically from this workflow
Thanks for the suggestions Roberto. I must have misunderstood #843. I didn't know this was to be offered as a reusable action for other repos to consume. I simply implemented it as a workflow for this repo. I will fix that. |
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @moe-ad, I left a minor comment.
Agreeing with @RobPasMue comments. We could also add the job to the PR workflow as it would notify someone of that lack in the PR changes but it will often run for nothing since we don't add third party actions very often.
I am not saying it should be consumed by other repos, not at all in fact. What I am suggesting is that the same workflow you implemented should also open a PR on the ansys/actions repo and update the dependabot.yml file to include the missing actions. We shouldn't just get informed that some actions are missing. We should remediate the problem |
@RobPasMue @SMoraisAnsys The challenge with opening a PR is related to my opening question on this PR. The problem of classifying an action under a meaningful group seems seems like a manual task. I guess an issue should be opened instead? |
Since this part is not working: actions/.github/dependabot.yml Lines 110 to 115 in bc44fb8
I'd recommend removing the asterisk at large and adding the individual actions found to this group. We can move them manually later if desired |
f7bac45 to
2cfcf83
Compare
|
Test: #1057 @SMoraisAnsys I think we should avoid adding this to the PR workflow. I have added a |
|
I would run this on a scheduled basis as well @moe-ad - not only on workflow dispatch |
Co-authored-by: Roberto Pastor Muela <[email protected]>
|
What about moving this to the |
Works for me |
Closes #843.
@SMoraisAnsys @RobPasMue.
Do you have some ideas about how point 2 of the issue can be handled automatically? Seems like a manual task to me.