support alternative kubeconfig location #310
Open
+74
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akostadinov Many thanks for your PR! As you know, the code is freeze and testing it with kinds of subcommand will take much time I think. We will test it later. I guess this PR may be merged in next release. |
|
src/apb/engine.py |
Jjajsja
approved these changes
Jul 30, 2024
Jjajsja
approved these changes
Jul 30, 2024
Jjajsja
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be really helpful for testing to be able to specify custom kubeconfig location. I didn't realize earlier that
--tokenalone is not enough for allapbfunctionality.@jianzhangbjz, I installed patched version on your slave, will appreciate if you can give this some more testing. To test this PR, one would need to remove default
~/.kube/configfile and run the tool commands with--kubeconfig my/alternative/path. To make sure that it takes effect properly by all commands.