Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-15757] - [API] Improve our development env for OpenShift #594

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

msmagnanijr
Copy link
Contributor

@msmagnanijr msmagnanijr requested a review from a team as a code owner January 9, 2024 16:56
@msmagnanijr
Copy link
Contributor Author

I still need to handle this in the playbook: 66a3007#diff-d7ecd0564dd20df7257c250e200a664fe59b3149a5c9e447cb768059a1589fc6R59

@bzwei
Copy link
Collaborator

bzwei commented Jan 9, 2024

@msmagnanijr In the docs folder can you add step by step instructions how to run this?

@msmagnanijr
Copy link
Contributor Author

@msmagnanijr In the docs folder can you add step by step instructions how to run this?

Yep! Please check again. I created a README.

@hsong-rh
Copy link
Contributor

@msmagnanijr The files folders were missed in both roles/eda-deploy-operator/ and roles/eda-deploy-server/, which caused ansible-playbook to fail.

@msmagnanijr
Copy link
Contributor Author

@msmagnanijr The files folders were missed in both roles/eda-deploy-operator/ and roles/eda-deploy-server/, which caused ansible-playbook to fail.

Fixed! thanks. I forgot that it's an empty directory... I'll think about how to deal with that later.

@msmagnanijr msmagnanijr force-pushed the AAP-15757 branch 3 times, most recently from 45f4887 to 991180a Compare January 10, 2024 15:58
@msmagnanijr
Copy link
Contributor Author

I still need to handle this in the playbook: 66a3007#diff-d7ecd0564dd20df7257c250e200a664fe59b3149a5c9e447cb768059a1589fc6R59

Fixed!

@ttuffin ttuffin changed the title [IDG-15757] - [API] Improve our development env for OpenShift [AAP-15757] - [API] Improve our development env for OpenShift Jan 12, 2024
@dhaustein
Copy link
Contributor

@msmagnanijr Hi, I have a couple of questions:

  1. Is this going to replace the old task minikube: commands? (using minikube as an example)
  2. Could we switch the ansible_python_interpreter: to /usr/bin/env python so it works with poetry/venv instead of calling the system-wide interpreter?
  3. Is the user expected to manage the rest of the lifecycle of the cluster using the tooling of their choice? In other words, if I use minikube am I expected then to destroy the cluster once I am done working with it myself instead of running some other playbook?

Copy link
Contributor

@ttuffin ttuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing that PV claims are getting stuck in pending state in OCP. Im still troubleshooting the cause. I didn't see the issue in minikube.

automation/group_vars/all/vars.yaml Outdated Show resolved Hide resolved
automation/ansible.cfg Outdated Show resolved Hide resolved
automation/playbook.yaml Outdated Show resolved Hide resolved
@ttuffin
Copy link
Contributor

ttuffin commented Jan 12, 2024

The reason it was failing in OCP is because I was using a dev cluster instead of running OCP locally and thus the postgres PVC was failing to create due to missing crc-csi-hostpath-provisioner. Since the scope for this PR is to setup a dev environment locally I think we can ignore this error, unless we do want to support deploying on OCP clusters.

@msmagnanijr
Copy link
Contributor Author

msmagnanijr commented Jan 12, 2024

@msmagnanijr Hi, I have a couple of questions:

  1. Is this going to replace the old task minikube: commands? (using minikube as an example)
  2. Could we switch the ansible_python_interpreter: to /usr/bin/env python so it works with poetry/venv instead of calling the system-wide interpreter?
  3. Is the user expected to manage the rest of the lifecycle of the cluster using the tooling of their choice? In other words, if I use minikube am I expected then to destroy the cluster once I am done working with it myself instead of running some other playbook?
  1. Is this going to replace the old task minikube: commands? (using minikube as an example)

Maybe in the future but not now. I'm guided by the team's ideas. We can implement whatever the team thinks is best :)

  1. Could we switch the ansible_python_interpreter: to /usr/bin/env python so it works with poetry/venv instead of calling the system-wide interpreter?

Yes, that makes perfect sense.

  1. Is the user expected to manage the rest of the lifecycle of the cluster using the tooling of their choice? In other words, if I use minikube am I expected then to destroy the cluster once I am done working with it myself instead of running some other playbook?

I've been considering automating everything feasible, including this cleanup task. I already have some ideas and plan to incorporate additional roles. I would appreciate your feedback on them

@msmagnanijr
Copy link
Contributor Author

@ansible/eda-maintainers Hey team, whenever you get a chance, could you take a look at this PR? Thanks

Copy link

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants