Skip to content

fix: [AAP-45298] Stuck in disabling/deleting an activation in ocp env #1319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

hsong-rh
Copy link
Contributor

https://issues.redhat.com/browse/AAP-45298

Rework PR to solve the timeout issue when disabling/deleting activations.

The output on the UI page after being disabled:
image

@hsong-rh hsong-rh requested a review from a team as a code owner May 22, 2025 20:51
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.29%. Comparing base (9e42a35) to head (7d56818).

@@            Coverage Diff             @@
##             main    #1319      +/-   ##
==========================================
- Coverage   94.56%   94.29%   -0.27%     
==========================================
  Files         318      318              
  Lines       18609    18518      -91     
==========================================
- Hits        17597    17461     -136     
- Misses       1012     1057      +45     
Flag Coverage Δ
unit-int-tests-3.11 94.23% <100.00%> (-0.28%) ⬇️
unit-int-tests-3.12 94.29% <100.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/aap_eda/services/activation/engine/kubernetes.py 81.58% <100.00%> (-15.58%) ⬇️
...tion/services/activation/engine/test_kubernetes.py 98.18% <100.00%> (-0.44%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hsong-rh hsong-rh force-pushed the aap-45298 branch 3 times, most recently from d1ebf96 to 563fd7f Compare May 27, 2025 14:14
Copy link

Copy link
Collaborator

@Alex-Izquierdo Alex-Izquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsong-rh hsong-rh merged commit ad521a4 into ansible:main May 27, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants