Run CI on feature branches #1115
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
I think we don't need it. The current config already runs the checks for every PR, I added the config in the repo to make the checks mandatory for feature branches, that's all I think we need. If we would have releases branches it could make sense to trigger it on push there, but it is not the case. Neither we are using merge groups, btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverages syntax defined here - https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#using-filters
Note that this currently just will run the CI, but will not upload the test results currently as defined in this task - https://github.com/ansible/eda-server/blob/main/.github/workflows/ci.yaml#L118