Pass authentication field to insights plugin #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch will add authentication: service_account to insights.yml if client_id is defined. Even though extra_vars is configured in the insights credential field, extra_vars is not utilized for inventory source syncs. As such, we can override the inventory_as_dict class on the Inventory plugin to inject "authentication: service_account" param into the insights.yml file. Signed-off-by: Seth Foster <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will add
authentication: service_accountto insights.yml if client_id is defined on the credential.
Even though extra_vars is configured in the insights credential field, extra_vars is not utilized for inventory source syncs.
As such, we can override the inventory_as_dict class on the Inventory plugin to inject "authentication: service_account" param into the insights.yml file.
in the inventory sync private data dir
inventory/insights.yml
the INSIGHTS_CLIENT_ID and INSIGHTS_CLIENT_SECRET are passed in via environment variables, which is supported by the insights module https://github.com/RedHatInsights/ansible-collections-insights/blob/43e169d6eb0a01d40b3a8df05070e372cb6fd862/docs/inventory.md