Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community.vmware: Remove sanity and unity tests #1803

Conversation

mariolenz
Copy link
Contributor

@mariolenz mariolenz commented May 24, 2023

Depends-On: ansible-collections/community.vmware#1747

Remove sanity and unity tests from community.vmware.

ansible-collections/community.vmware#1746

@softwarefactory-project-zuul
Copy link
Contributor

Zuul encountered a syntax error while parsing its configuration in the
repo ansible/ansible-zuul-jobs on branch master. The error was:

Unknown projects: github.com/ansible-collections/amazon.cloud

The error appears in the following job stanza:

job:
name: tox-cloud-refresh-examples-amazon
parent: tox
description: |
Refresh the example using gouttelette.
required-projects:
- name: github.com/ansible-collections/amazon.cloud
- name: github.com/ansible-collections/gouttelette
nodeset: container-ansible
vars:
tox_envlist: refresh-examples
tox_package_name: amazon_cloud
zuul_work_dir: "~/{{ zuul.projects['github.com/ansible-collections/amazon.cloud'].src_dir }}"

in "ansible/ansible-zuul-jobs/zuul.d/ansible-cloud-jobs.yaml@master", line 692, column 3

@mariolenz mariolenz closed this May 24, 2023
@mariolenz mariolenz reopened this May 24, 2023
@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change with an invalid configuration.

@mariolenz
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change with an invalid configuration.

@mariolenz mariolenz changed the title [WIP] community.vmware: Remove sanity and unity tests community.vmware: Remove sanity and unity tests May 24, 2023
@mariolenz
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Zuul encountered a syntax error while parsing its configuration in the
repo ansible/ansible-zuul-jobs on branch master. The error was:

Unknown projects: github.com/ansible-collections/amazon.cloud

The error appears in the following job stanza:

job:
name: tox-cloud-refresh-examples-amazon
parent: tox
description: |
Refresh the example using gouttelette.
required-projects:
- name: github.com/ansible-collections/amazon.cloud
- name: github.com/ansible-collections/gouttelette
nodeset: container-ansible
vars:
tox_envlist: refresh-examples
tox_package_name: amazon_cloud
zuul_work_dir: "~/{{ zuul.projects['github.com/ansible-collections/amazon.cloud'].src_dir }}"

in "ansible/ansible-zuul-jobs/zuul.d/ansible-cloud-jobs.yaml@master", line 692, column 3

@mariolenz
Copy link
Contributor Author

@alinabuzachis @GomathiselviS @gravesm I don't understand the error I'm running into here. Do you think it can have something to do with #1797?

jillr
jillr previously approved these changes May 24, 2023
Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@jillr jillr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the PR open too long and didn't see the syntax error from the last test run, clearing my review

@jillr jillr dismissed their stale review May 24, 2023 17:42

I had the PR open too long and didn't see the syntax error from the last test run, clearing my review

@mariolenz
Copy link
Contributor Author

@jillr Any idea why this fails? As far as I can see, my changes didn't touch anything about amazon.cloud at all 🤷

@gravesm
Copy link
Member

gravesm commented May 24, 2023

@mariolenz I think this is cause by the amazon.cloud project being removed from https://github.com/ansible/zuul-config. Double checking but I think we may just need to remove the jobs that reference the amazon.cloud project from here.

@GomathiselviS
Copy link
Collaborator

This PR should fix the issue.

@GomathiselviS
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7cb4dc411ef04cf996e9a4df5667e9f3

✔️ ansible-tox-linters SUCCESS in 10m 47s
✔️ ansible-tox-py38 SUCCESS in 11m 12s
✔️ ansible-tox-py39 SUCCESS in 10m 58s
✔️ ansible-tox-py310 SUCCESS in 10m 52s

@jillr jillr added the mergeit Merge the PR (SoftwareFActory) label May 24, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/f52f2783890846019db0a7a0decf665e

✔️ ansible-tox-linters SUCCESS in 10m 27s
✔️ ansible-tox-py38 SUCCESS in 10m 59s
✔️ ansible-tox-py39 SUCCESS in 12m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b8064ad into ansible:master May 24, 2023
@mariolenz mariolenz deleted the 20230524_c.v_remove_sanity_unit_tests branch May 24, 2023 20:27
@mariolenz
Copy link
Contributor Author

Thanks @GomathiselviS @gravesm @jillr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFActory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants