Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable FQCNs for import_playbook to have subdirs #4412

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cavcrosby
Copy link
Contributor

Related to #4362.

@cavcrosby
Copy link
Contributor Author

cavcrosby commented Nov 16, 2024

Regarding the code analysis failing, ansible uses a similar regex that does not place a limit on the number of subdirectories a user can specify. Currently, I think that's the only applicable workaround to the catastrophic backtracking vulnerability, but even then, I don't think the linter should differ from what ansible sets.

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE_IS_FQCN_OR_NAME = re.compile(r"^\w+((\.\w+){2,})*$")

To quote SonarQube: Make sure the regex used here, which is vulnerable to exponential runtime due to backtracking, cannot lead to denial of service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants