-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accommodate specified inventory files #4393
Open
cavcrosby
wants to merge
1
commit into
ansible:main
Choose a base branch
from
cavcrosby:add-inventory-option
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+176
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 10, 2024 00:24
a5e6c76
to
7595e5f
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 10, 2024 00:32
7595e5f
to
cfedf17
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 10, 2024 20:47
cfedf17
to
9a5e309
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 11, 2024 15:14
9a5e309
to
e5eac53
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 12, 2024 23:51
e5eac53
to
c5bf8c5
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 14, 2024 00:43
c5bf8c5
to
5f56898
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 15, 2024 23:35
5f56898
to
ee4cf85
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 16, 2024 15:14
ee4cf85
to
f9e104a
Compare
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 22, 2024 14:21
f92d14d
to
c8e4e98
Compare
The ansible_cfg_inventory conditional in the _get_inventory_files method is used because otherwise, when not passing in an inventory file via CLI, inventory_files would set to the /etc/ansible/hosts (the default value for the DEFAULT_HOST_LIST config). In most cases, I'd presume that wouldn't be desired.
cavcrosby
force-pushed
the
add-inventory-option
branch
from
November 24, 2024 23:17
c8e4e98
to
12c1678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4241 and #4225.
I alluded to this in the former issue, but I believe it was intended that
ansible-lint
would accommodate the inventory files used. Though, for whatever reason, it seems this functionality has been missing.