Make ignore_unreachable accept jinja templates (#4120)

ansible · Apr 30, 2024 · dfb8fea · dfb8fea
1 parent 9ee0c98
commit dfb8fea
Show file tree

Hide file tree

Showing 6 changed files with 371 additions and 16 deletions.
diff --git a/src/ansiblelint/schemas/ansible.json b/src/ansiblelint/schemas/ansible.json
@@ -168,7 +168,7 @@
         },
         "ignore_unreachable": {
           "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean"
         },
         "module_defaults": {
           "title": "Module Defaults"
@@ -528,7 +528,7 @@
         },
         "ignore_unreachable": {
           "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean"
         },
         "max_fail_percentage": {
           "title": "Max Fail Percentage",
@@ -732,7 +732,7 @@
         },
         "ignore_unreachable": {
           "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean"
         },
         "module_defaults": {
           "title": "Module Defaults"
@@ -935,7 +935,7 @@
         },
         "ignore_unreachable": {
           "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean"
         },
         "listen": {
           "anyOf": [

diff --git a/src/ansiblelint/schemas/playbook.json b/src/ansiblelint/schemas/playbook.json
@@ -171,8 +171,8 @@
           "$ref": "#/$defs/ignore_errors"
         },
         "ignore_unreachable": {
-          "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean",
+          "title": "Ignore Unreachable"
         },
         "module_defaults": {
           "title": "Module Defaults"
@@ -537,8 +537,8 @@
           "$ref": "#/$defs/ignore_errors"
         },
         "ignore_unreachable": {
-          "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean",
+          "title": "Ignore Unreachable"
         },
         "max_fail_percentage": {
           "$ref": "#/$defs/templated-integer",
@@ -747,8 +747,8 @@
           "$ref": "#/$defs/ignore_errors"
         },
         "ignore_unreachable": {
-          "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean",
+          "title": "Ignore Unreachable"
         },
         "module_defaults": {
           "title": "Module Defaults"
@@ -947,8 +947,8 @@
           "$ref": "#/$defs/ignore_errors"
         },
         "ignore_unreachable": {
-          "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean",
+          "title": "Ignore Unreachable"
         },
         "include": {
           "$ref": "#/$defs/removed-include-module"

diff --git a/src/ansiblelint/schemas/tasks.json b/src/ansiblelint/schemas/tasks.json
@@ -123,8 +123,8 @@
           "$ref": "#/$defs/ignore_errors"
         },
         "ignore_unreachable": {
-          "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean",
+          "title": "Ignore Unreachable"
         },
         "module_defaults": {
           "title": "Module Defaults"
@@ -382,8 +382,8 @@
           "$ref": "#/$defs/ignore_errors"
         },
         "ignore_unreachable": {
-          "title": "Ignore Unreachable",
-          "type": "boolean"
+          "$ref": "#/$defs/templated-boolean",
+          "title": "Ignore Unreachable"
         },
         "include": {
           "$ref": "#/$defs/removed-include-module"

diff --git a/test/schemas/negative_test/playbooks/ignore-unreachable.yml b/test/schemas/negative_test/playbooks/ignore-unreachable.yml
@@ -0,0 +1,13 @@
+---
+- name: Test
+  hosts: localhost
+  tasks:
+    - name: Debug
+      ansible.builtin.debug:
+        msg: ignore_unreachable should not be a string
+      ignore_unreachable: "yes"
+
+    - name: Debug
+      ansible.builtin.debug:
+        msg: jinja evaluation should not be a string
+      ignore_unreachable: 123