-
Notifications
You must be signed in to change notification settings - Fork 670
add details on some plugin options - AI-assisted #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Okay made the changes. Can you take another look @felixfontein ? |
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the following, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @samccann
Co-authored-by: Andrew Klychkov <[email protected]>
Backport to stable-2.17: 💚 backport PR created✅ Backport PR branch: Backported as #2899 🤖 @patchback |
* add details on some plugin options * revise based on feedback * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review Co-authored-by: Don Naro <[email protected]> * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit caa2399)
Backport to stable-2.18: 💚 backport PR created✅ Backport PR branch: Backported as #2900 🤖 @patchback |
* add details on some plugin options * revise based on feedback * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review Co-authored-by: Don Naro <[email protected]> * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit caa2399)
Backport to stable-2.19: 💚 backport PR created✅ Backport PR branch: Backported as #2901 🤖 @patchback |
* add details on some plugin options * revise based on feedback * Apply suggestions from code review Co-authored-by: Felix Fontein <[email protected]> * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review Co-authored-by: Don Naro <[email protected]> * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst Co-authored-by: Felix Fontein <[email protected]> * Apply suggestions from code review Co-authored-by: Andrew Klychkov <[email protected]> --------- Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]> (cherry picked from commit caa2399)
* add details on some plugin options * revise based on feedback * Apply suggestions from code review * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review --------- (cherry picked from commit caa2399) Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]>
* add details on some plugin options * revise based on feedback * Apply suggestions from code review * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review --------- (cherry picked from commit caa2399) Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]>
* add details on some plugin options * revise based on feedback * Apply suggestions from code review * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review * add examples * Update docs/docsite/rst/dev_guide/developing_plugins.rst * Apply suggestions from code review --------- (cherry picked from commit caa2399) Co-authored-by: Sandra McCann <[email protected]> Co-authored-by: Felix Fontein <[email protected]> Co-authored-by: Don Naro <[email protected]> Co-authored-by: Andrew Klychkov <[email protected]>
Fixes #2673
Should have done this in 2 commits (AI-generated, then human adapted). Lines 78-93 are predominantly generated.
To fix this bug, I fed the following into Cursor chat mode:
Fix the documentation problems from @https://github.com/ansible/ansible-documentation/issues/2673