Skip to content

add details on some plugin options - AI-assisted #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 24, 2025

Conversation

samccann
Copy link
Contributor

@samccann samccann commented Jul 14, 2025

Fixes #2673

Should have done this in 2 commits (AI-generated, then human adapted). Lines 78-93 are predominantly generated.

To fix this bug, I fed the following into Cursor chat mode:
Fix the documentation problems from @https://github.com/ansible/ansible-documentation/issues/2673

@samccann
Copy link
Contributor Author

Okay made the changes. Can you take another look @felixfontein ?

@samccann samccann requested review from oraNod and Andersson007 July 15, 2025 20:44
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the following, LGTM

Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @samccann

@samccann samccann added the backport-2.17 Automatically create a backport for the stable-2.17 branch label Jul 24, 2025
@samccann samccann added backport-2.18 Automatically create a backport for the stable-2.18 branch backport-2.19 Automatically create a backport for the stable-2.19 branch labels Jul 24, 2025
@samccann samccann merged commit caa2399 into ansible:devel Jul 24, 2025
12 checks passed
Copy link

patchback bot commented Jul 24, 2025

Backport to stable-2.17: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.17/caa2399fa45dfe3165646d325f3c434962551a50/pr-2813

Backported as #2899

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@samccann samccann deleted the env-try branch July 24, 2025 13:24
patchback bot pushed a commit that referenced this pull request Jul 24, 2025
* add details on some plugin options

* revise based on feedback

* Apply suggestions from code review

Co-authored-by: Felix Fontein <[email protected]>

* Update docs/docsite/rst/dev_guide/developing_plugins.rst

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* add examples

* Update docs/docsite/rst/dev_guide/developing_plugins.rst

Co-authored-by: Felix Fontein <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andrew Klychkov <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
(cherry picked from commit caa2399)
Copy link

patchback bot commented Jul 24, 2025

Backport to stable-2.18: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.18/caa2399fa45dfe3165646d325f3c434962551a50/pr-2813

Backported as #2900

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 24, 2025
* add details on some plugin options

* revise based on feedback

* Apply suggestions from code review

Co-authored-by: Felix Fontein <[email protected]>

* Update docs/docsite/rst/dev_guide/developing_plugins.rst

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* add examples

* Update docs/docsite/rst/dev_guide/developing_plugins.rst

Co-authored-by: Felix Fontein <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andrew Klychkov <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
(cherry picked from commit caa2399)
Copy link

patchback bot commented Jul 24, 2025

Backport to stable-2.19: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2.19/caa2399fa45dfe3165646d325f3c434962551a50/pr-2813

Backported as #2901

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 24, 2025
* add details on some plugin options

* revise based on feedback

* Apply suggestions from code review

Co-authored-by: Felix Fontein <[email protected]>

* Update docs/docsite/rst/dev_guide/developing_plugins.rst

* Apply suggestions from code review

Co-authored-by: Don Naro <[email protected]>

* add examples

* Update docs/docsite/rst/dev_guide/developing_plugins.rst

Co-authored-by: Felix Fontein <[email protected]>

* Apply suggestions from code review

Co-authored-by: Andrew Klychkov <[email protected]>

---------

Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
(cherry picked from commit caa2399)
samccann added a commit that referenced this pull request Jul 24, 2025
* add details on some plugin options

* revise based on feedback

* Apply suggestions from code review



* Update docs/docsite/rst/dev_guide/developing_plugins.rst

* Apply suggestions from code review



* add examples

* Update docs/docsite/rst/dev_guide/developing_plugins.rst



* Apply suggestions from code review



---------




(cherry picked from commit caa2399)

Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
samccann added a commit that referenced this pull request Jul 24, 2025
* add details on some plugin options

* revise based on feedback

* Apply suggestions from code review



* Update docs/docsite/rst/dev_guide/developing_plugins.rst

* Apply suggestions from code review



* add examples

* Update docs/docsite/rst/dev_guide/developing_plugins.rst



* Apply suggestions from code review



---------




(cherry picked from commit caa2399)

Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
samccann added a commit that referenced this pull request Jul 24, 2025
* add details on some plugin options

* revise based on feedback

* Apply suggestions from code review



* Update docs/docsite/rst/dev_guide/developing_plugins.rst

* Apply suggestions from code review



* add examples

* Update docs/docsite/rst/dev_guide/developing_plugins.rst



* Apply suggestions from code review



---------




(cherry picked from commit caa2399)

Co-authored-by: Sandra McCann <[email protected]>
Co-authored-by: Felix Fontein <[email protected]>
Co-authored-by: Don Naro <[email protected]>
Co-authored-by: Andrew Klychkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2.17 Automatically create a backport for the stable-2.17 branch backport-2.18 Automatically create a backport for the stable-2.18 branch backport-2.19 Automatically create a backport for the stable-2.19 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module format and documentation missing env
4 participants