Skip to content

Ansible code bot recommendations #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ansible code bot recommendations #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/run/tasks/health_checks/eos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show ip bgp summary"
command: show ip bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
Expand Down
2 changes: 1 addition & 1 deletion roles/run/tasks/health_checks/ios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show bgp summary"
command: show bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
2 changes: 1 addition & 1 deletion roles/run/tasks/health_checks/iosxr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show bgp summary"
command: show bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
3 changes: 1 addition & 2 deletions roles/run/tasks/health_checks/junos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show bgp summary"
command: show bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health


- name: Show Summary facts
ansible.builtin.debug:
msg: "{{ bgp_health }}"
2 changes: 1 addition & 1 deletion roles/run/tasks/health_checks/nxos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show ip bgp summary"
command: show ip bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
2 changes: 1 addition & 1 deletion roles/run/tasks/health_checks/vyos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show ip bgp summary"
command: show ip bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/configure.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
ansible.builtin.include_role:
name: network.base.resource_manager
vars:
operation: 'configure'
operation: configure
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/deploy.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
ansible.builtin.include_role:
name: network.base.resource_manager
vars:
operation: 'deploy'
operation: deploy
resources: "{{ bgp_resources }}"
4 changes: 2 additions & 2 deletions roles/run/tasks/includes/detect.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
ansible.builtin.include_role:
name: network.base.resource_manager
vars:
operation: 'detect'
state: 'replaced'
operation: detect
state: replaced
resources: "{{ bgp_resources }}"
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/gather.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
ansible.builtin.include_role:
name: network.base.resource_manager
vars:
operation: 'gather'
operation: gather
resources: "{{ bgp_resources }}"
4 changes: 2 additions & 2 deletions roles/run/tasks/includes/health_check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

- name: Set health checks fact
ansible.builtin.set_fact:
health_checks: "{{ bgp_health | network.bgp.health_check_view(operation) }}"
health_checks: "{{ bgp_health | network.bgp.health_check_view(operation) }}"

- name: BGP health checks
ansible.builtin.debug:
var: health_checks
var: health_checks
failed_when: "'unsuccessful' == health_checks.status"
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/health_checks/eos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show ip bgp summary"
command: show ip bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/health_checks/ios.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show bgp summary"
command: show bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/health_checks/iosxr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show bgp summary"
command: show bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
3 changes: 1 addition & 2 deletions roles/run/tasks/includes/health_checks/junos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show bgp summary"
command: show bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health


- name: Show Summary facts
ansible.builtin.debug:
msg: "{{ bgp_health }}"
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/health_checks/nxos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show ip bgp summary"
command: show ip bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/health_checks/vyos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
- name: Parse bgp summary
ansible.utils.cli_parse:
command: "show ip bgp summary"
command: show ip bgp summary
parser:
name: ansible.netcommon.content_templates
set_fact: bgp_health
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/list.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
ansible.builtin.include_role:
name: network.base.resource_manager
vars:
operation: 'list'
operation: list
2 changes: 1 addition & 1 deletion roles/run/tasks/includes/persist.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
ansible.builtin.include_role:
name: network.base.resource_manager
vars:
operation: 'persist'
operation: persist
resources: "{{ bgp_resources }}"
ignore_empty: "{{ persist_empty | default(true) }}"
4 changes: 2 additions & 2 deletions roles/run/tasks/includes/remediate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
ansible.builtin.include_role:
name: network.base.resource_manager
vars:
operation: 'remediate'
state: 'replaced'
operation: remediate
state: replaced
resources: "{{ bgp_resources }}"
10 changes: 5 additions & 5 deletions roles/run/tasks/includes/resources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
- name: Set resources
ansible.builtin.set_fact:
bgp_resources:
- 'bgp_global'
- 'bgp_address_family'
- 'bgp_neighbor_address_family'
- bgp_global
- bgp_address_family
- bgp_neighbor_address_family
when: ansible_network_os == 'cisco.nxos.nxos'

- name: Set resources
ansible.builtin.set_fact:
bgp_resources:
- 'bgp_global'
- 'bgp_address_family'
- bgp_global
- bgp_address_family
when: ansible_network_os != 'cisco.nxos.nxos'