Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Alma 8 GPG Key #369

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Update Alma 8 GPG Key #369

merged 2 commits into from
Jun 14, 2024

Conversation

ajython
Copy link
Contributor

@ajython ajython commented Apr 23, 2024

Update AlmaLinux.yml

Overall Review of Changes:
Following Alma 8 GPG change, the new GPG key needs updating.

Issue Fixes:
Please list (using linking) any open issues this PR addresses

Enhancements:
Please list any enhancements/features that are not open issue tickets

How has this been tested?:
N/A

Update AlmaLinux.yml

Signed-off-by: ajython <[email protected]>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on opening your first pull request and thank you for taking the time to help improve Ansible-Lockdown!
Please join in the conversation happening on the Discord Server as well.

Copy link

@nickthebeer nickthebeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uk-bolly
uk-bolly previously approved these changes Jun 12, 2024
Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant and explanation link included

@uk-bolly uk-bolly dismissed their stale review June 12, 2024 08:30

see comments

@uk-bolly
Copy link
Member

uk-bolly commented Jun 12, 2024

Hi

Thank you for taking the time to raise this PR, really appreciate the fact the url is also added to show the reasoning behind this.
However while all looks good the value that is searched for in the command works a little different.
We are looking for the keyID reference from the release package. in this case the value would be 2ae81e8aced7258b.
This can be seen in the check command that is run in the tasks (it discovers the release rpm)

rpm -q --queryformat "%{PACKAGER} %{SIGPGP:pgpsig}\n" almalinux-release-8.10-1.el8.x86_64

The link that you provided really helped to point us in the correct direction.

If you want to change the value and add to README, happy to accept the PR or i am able to bring this into another PR i'm currently working on.

Many thanks

uk-bolly

p.s. Also thinking a pre-check maybe a good idea to ensure the version of the release package is 8.8-3 as minimum for alma

@uk-bolly uk-bolly linked an issue Jun 14, 2024 that may be closed by this pull request
Replace depricated Alma 8 GPG key 

Signed-off-by: ajython <[email protected]>
@ajython
Copy link
Contributor Author

ajython commented Jun 14, 2024

Hello,
I've updated the PR with the new KeyID. Feel free to merge it with your PR if this needs more work.
Thanks

@uk-bolly
Copy link
Member

Hello, I've updated the PR with the new KeyID. Feel free to merge it with your PR if this needs more work. Thanks

Brilliant work thank you, always nice to be able to merge someone PR rather than add credits.

Thank you

uk-bolly

@uk-bolly uk-bolly merged commit 0f4f7b3 into ansible-lockdown:devel Jun 14, 2024
4 checks passed
uk-bolly added a commit that referenced this pull request Jun 20, 2024
* initial v3.0.0

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* removed old conflict line

Signed-off-by: Mark Bolwell <[email protected]>

* tidy up warning on 432

Signed-off-by: Mark Bolwell <[email protected]>

* tidy up ec2_checks

Signed-off-by: Mark Bolwell <[email protected]>

* updated warning on line 435

Signed-off-by: Mark Bolwell <[email protected]>

* updated prelim and typos

Signed-off-by: Mark Bolwell <[email protected]>

* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/ansible-community/ansible-lint: v24.2.0 → v24.2.1](ansible/ansible-lint@v24.2.0...v24.2.1)

* March 24 updates (#356)

* added conditional to user password check #354 thanks to @bbaassssiiee

Signed-off-by: Mark Bolwell <[email protected]>

* updated logic to check root passwd locked

Signed-off-by: Mark Bolwell <[email protected]>

* Updated

Signed-off-by: Mark Bolwell <[email protected]>

* lint and audit order change

Signed-off-by: Mark Bolwell <[email protected]>

* updated for documentation format

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>

* Allow for a local site policy for the openSSH server. (#358)

If changes to the system-wide crypto policy are required to meet local
site policy for the openSSH server, these changes should be done with a sub-policy
assigned to the system-wide crypto policy.

The role defaults can be overridden by the user's vars.
The user should implement a .pmod file, and add its basename to `rhel8cis_allowed_crypto_policies_modules`.
The role vars are harder to change due to the 21 priority levels of Ansible.

Signed-off-by: Bas Meijer <[email protected]>

* Issues March24 (#366)

* #359 addressed thanks to @bbaassssiiee

Signed-off-by: Mark Bolwell <[email protected]>

* sysctl matches requirement & handler added

Signed-off-by: Mark Bolwell <[email protected]>

* container updated and cautions updated

Signed-off-by: Mark Bolwell <[email protected]>

* issues #360 addressed thanks to @bbaassssiiee

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* Added #361 ensure local interface on 3.4.2.2

Signed-off-by: Mark Bolwell <[email protected]>

* issue #363 addressed

Signed-off-by: Mark Bolwell <[email protected]>

* variable naming and lint

Signed-off-by: Mark Bolwell <[email protected]>

* variable naming and lint

Signed-off-by: Mark Bolwell <[email protected]>

* updated handler

Signed-off-by: Mark Bolwell <[email protected]>

* variable naming and lint updates

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* fix issues with pam_unix

Signed-off-by: Mark Bolwell <[email protected]>

* added extra options

Signed-off-by: Mark Bolwell <[email protected]>

* issue #365 addressed

Signed-off-by: Mark Bolwell <[email protected]>

* fixed commenting alternate file

Signed-off-by: Mark Bolwell <[email protected]>

* updated var name to discovered

Signed-off-by: Mark Bolwell <[email protected]>

* renamed variable tomake it clearer

Signed-off-by: Mark Bolwell <[email protected]>

* updated

Signed-off-by: Mark Bolwell <[email protected]>

* fix typo

Signed-off-by: Mark Bolwell <[email protected]>

* updated discovered variable naming

Signed-off-by: Mark Bolwell <[email protected]>

* updated variable naming

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>

* [pre-commit.ci] pre-commit autoupdate (#367)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* [pre-commit.ci] pre-commit autoupdate (#368)

updates:
- [github.com/ansible-community/ansible-lint: v24.2.1 → v24.2.2](ansible/ansible-lint@v24.2.1...v24.2.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* updated for audit and url alignment (#370)

Signed-off-by: Mark Bolwell <[email protected]>

* [pre-commit.ci] pre-commit autoupdate (#372)

updates:
- [github.com/Yelp/detect-secrets: v1.4.0 → v1.5.0](Yelp/detect-secrets@v1.4.0...v1.5.0)
- [github.com/gitleaks/gitleaks: v8.18.2 → v8.18.3](gitleaks/gitleaks@v8.18.2...v8.18.3)
- [github.com/ansible-community/ansible-lint: v24.2.2 → v24.6.0](ansible/ansible-lint@v24.2.2...v24.6.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* use RHEL8 chrony.conf (#371)

Signed-off-by: Tomáš Kuba <[email protected]>

* Update Alma 8 GPG Key (#369)

* Update Alma 8 GPG Key

Update AlmaLinux.yml

Signed-off-by: ajython <[email protected]>

* Update AlmaLinux.yml

Replace depricated Alma 8 GPG key 

Signed-off-by: ajython <[email protected]>

---------

Signed-off-by: ajython <[email protected]>

* May 24 updates (#376)

* updated path to match disa for audit tools

Signed-off-by: Mark Bolwell <[email protected]>

* updated dict control

Signed-off-by: Mark Bolwell <[email protected]>

* updated nullok logic

Signed-off-by: Mark Bolwell <[email protected]>

* updated typos

Signed-off-by: Mark Bolwell <[email protected]>

* updated typ thanks to @msachikanta

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>

* [pre-commit.ci] pre-commit autoupdate (#383)

updates:
- [github.com/gitleaks/gitleaks: v8.18.3 → v8.18.4](gitleaks/gitleaks@v8.18.3...v8.18.4)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* updated known issues thanks to @fgierlinger

Signed-off-by: Mark Bolwell <[email protected]>

* Interactive users logic and workflow (#385)

* interactive user vars updates

Signed-off-by: Mark Bolwell <[email protected]>

* improved conditionals checks

Signed-off-by: Mark Bolwell <[email protected]>

* Tidy up titles

Signed-off-by: Mark Bolwell <[email protected]>

* updated with latest devel

Signed-off-by: Mark Bolwell <[email protected]>

* removed file not required

Signed-off-by: Mark Bolwell <[email protected]>

* improved logic for /dev/null home dirs

Signed-off-by: Mark Bolwell <[email protected]>

* Updated workflow to new runner

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>

---------

Signed-off-by: Mark Bolwell <[email protected]>
Signed-off-by: Bas Meijer <[email protected]>
Signed-off-by: Tomáš Kuba <[email protected]>
Signed-off-by: ajython <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Bas <[email protected]>
Co-authored-by: tomkuba <[email protected]>
Co-authored-by: ajython <[email protected]>
Co-authored-by: Fred W <[email protected]>
@uk-bolly uk-bolly mentioned this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Almalinux 8.10 has been released
3 participants