Promote vmware guest #4

This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@19c2029

Ensure the idempotency of the module if we try to delete a NIC two times in a row. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@8bd5dbc

This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@d3a624a

If new disk filename is not specified, vmware esxi will set new disk filename with a not ever used index, so even recreate new disk with same controller number and same unit number, filename existence failure would not occur. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@592db1a

Handle list items in vSphere schema while handling facts in vmware_guest_info Fixes: ansible-collections/community.vmware#33 Signed-off-by: Abhijeet Kasurde <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@6a4fe4f

setup_dvswitch: bump switch_version to 6.5.0 Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@63016a9

tox: enable flake8 Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@1e3c31c

Vmware module maintenance Reviewed-by: Chris Holland https://github.com/ChrisAHolland This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c66943b

Update Hardware version to include 15 - 6.7U2 Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c701885

zuul: define govcsim target Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@90734d6

define vcenter_1esxi_with_nested alias Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a6f6ec3

prepare_vmware_tests: isolate the 'VM Network' Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@d515ccf

re-enable vmware_guest_network test Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@145020c

vmware_guest_tools_wait: reenable the test Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@d0f71a9

temporarily disable vmware_guest_network Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@060cc99

Temporarily disable Tag and Category tests Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@57ff0cc

Revert "temporarily disable vmware_guest_network (#131)" Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@30fa288

VMware: add hardware version 17 support in vmware_guest module Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@66ae027

…tions#65) VMware: add SATA cdrom support in vmware_guest module Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@7377548

…rk (ansible-collections#29) Add check mode, diff and some new functionality to vmware_guest_network Reviewed-by: Gonéri Le Bouder <[email protected]> https://github.com/goneri This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@4c9869c

Include FQCN in module examples Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@3c4b40f

galaxy: ensure the import works Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@506655d

Removed ANSIBLE_METADATA from all the modules Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@e096903

vmware_guest: add support for SATA and NVME disk controller types Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@7d318b6

vmware_guest_disk: add sharing (multi-writer) capability Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@da35399

Revert "Temporarily disable Tag and Category tests" Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@47da547

test: add ability to run govcsim with systemd-run Reviewed-by: Gonéri Le Bouder <[email protected]> https://github.com/goneri This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@068d3b3

…ansible-collections#11) VMware: Match state param in vmware_guest and vmware_guest_powerstate Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@9d5dff3

vcsim/systemd: use the full path to vcsim Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@3fc87eb

Use FQCN to M() references Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@8338f38

tests: remove shippable entries from aliases Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ba54d85

vmware_guest: convert cdrom controller_number and unit_number parameters to integer firstly Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@1a3f7a4

…licitly ansible-collections#37 (#295) Reset disk['destroy'] to False when user set not remove disk file explicitly ansible-collections#37 Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@9fd3e46

sanity: pylint fixes Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ecb2dc0

sanity: Doc fixes for vmware_guest Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@23f3621

vmware_guest: Deprecate CDROM config as dict Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@110fd77

Fix vmware_guest_serial_port to have idempotency Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@304b96f

Support special characters in an object name Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@df1bc69

Ensure that VM are created on the requested ESXi host Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@34ef77f

vmware_guest_network: Fix to port group changes to work properly Reviewed-by: Abhijeet Kasurde https://github.com/Akasurde This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c1a375e

…isk controller is nvme (#384) vmware_guest: fix issue of checking specified hardware version when disk controller is nvme Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@43dfbda

Fix the special characters aren't decoded by the find_obj method Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@54403d6

replace yes with true and no with false Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a302a6b

tox: run yamllint Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c85ce53

…ions (#510) vmware_guest: Document networks connected and start_connected sub-options Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@26ffcd0

Shorten URL for vApp Properties Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@4be445d

… disks / vNICs (#552) vmware_guest: Fix an issue with vSphere 7 when adding several HDDs / NICs Reviewed-by: Gonéri Le Bouder <[email protected]> https://github.com/goneri This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c21bce7

update teardown to support vsphere 7.0u1 Reviewed-by: Gonéri Le Bouder <[email protected]> https://github.com/goneri This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c1cf303

vmware_guest_disk: add SATA and NVMe disk support Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@419edb2

vmware_guest: handle computer name while customization Reviewed-by: Abhijeet Kasurde https://github.com/Akasurde This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@0ba8d29

…ram (#533) vmware_resource_pool: add integration test for using esxi_hostname param Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@8108c35

ensure the sanity tests pass with 2.10.5 Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@92f04d3

…ument_spec (#595) vmware_guest: Define sub-options of hardware and customization in argument_spec Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@cc929fc

vmware_guest_register_operation: Support the check mode Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@1989ad6

vmware_content_deploy_template: Make parameter optional Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a606edd

vmware_guest: Remove unnecessary hardware version check Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c2ae755

Fix vmware_guest advanced_settings and customvalues Reviewed-by: Abhijeet Kasurde https://github.com/Akasurde This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@d5d00e3

vmware_guest: Define sub-options of disk in argument_spec Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@f454234

New module: vmware_guest_instant_clone Reviewed-by: Abhijeet Kasurde https://github.com/Akasurde This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@114df43

vmware_guest: Correct check for advanced_settings Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@f913056

vmware_guest: Fix disk parameter validation Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@5a2fb73

New module: vmware_guest_storage_policy Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@5272b43

vmware_guest: Fix integration test Reviewed-by: Ansibullbot manages ticket workflow https://github.com/ansibullbot This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@118cca1

vmware_guest_instant_clone: CI test starts VM Reviewed-by: Ansibullbot manages ticket workflow https://github.com/ansibullbot This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@f5c3e81

CI: ensure vmware_guest tests only run on nested capable host Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@cab1ba7

vmware_guest_instance_clone: tests: Unable to set power state Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@2f9c504

vmware_guest_storage_policy: test need datastore Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@e9afc9f

vmware_guest_storage_policy: test: don't clean up the test VM Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@0cc9584

tests: dont test the _facts modules Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@7c10fad

…sts (#760) vmware_guest_instant_clone: properly initialize the env before the tests Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@8b2c1e0

vmware_guest_register_operation: fix the test-suite Reviewed-by: Gonéri Le Bouder <[email protected]> https://github.com/goneri This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@8c8c041

…tate (#790) vmware_tag: Modify the category_id parameter to be required for all state Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@94d650c

…ion (#743) vmware_dvs_portgroup: MAC learning, elastic PGs and uplink configuration Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@492cee0

Clarify is_template in vmware_guest docs Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@78593dd

Skip customvalues while deploying VM on a standalone ESXi Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@99b916d

…lt for the future (#766) vmware_cluster_drs/ha/vsan: Announce change of enable parameter default for the future Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ad00aaa

vmware_guest - add integration test for delete_vm Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@d3cd76e

vmware_guest: Improve virtualization based security Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@88662da

Adding GuestOs Customization for Instant Clone feature Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@8bfb813

vmware_guest: Fix hostname is None when not used in playbook. Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@1702ead

Fix multiple content deploy issues Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@628efca

… the vm (#821) vmware_guest_powerstate: Add the answer option to require in starting the vm Reviewed-by: https://github.com/apps/ansible-zuul This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@99eef38

Move PyVmomiDeviceHelper to module_utils.vm_device_helper SUMMARY I think we should move the class PyVmomiDeviceHelper from vmware_guest to a module util. This way, we can use it in other modules (like vmware_guest_disk) and avoid duplicate code. In the long run, I hope this'll make it easier for us to maintain this collection. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Context: #905 Reviewed-by: Diane Wang <None> Reviewed-by: sky-joker <[email protected]> Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: Abhijeet Kasurde <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@6643fc3

…as been occurring (#924) vmware_guest_powerstate: Fix an error that the datacenter key error has been occurring Depends-on #945 SUMMARY vmware_guest_powerstate module has a bug that datacenter key error has been occurring if the same VM name is detected in VCSA. The datacenter parameter should be required in the get_vm method if the same VM name is detected. https://github.com/ansible-collections/community.vmware/blob/main/plugins/module_utils/vmware.py#L1208-L1221 So, this PR will add the datacenter parameter to the module to fix the bug. fixes: #921 ISSUE TYPE Bugfix Pull Request COMPONENT NAME changelogs/fragments/924-vmware_guest_powerstate.yml docs/community.vmware.vmware_guest_powerstate_module.rst plugins/modules/vmware_guest_powerstate.py tests/integration/targets/vmware_guest_powerstate/tasks/main.yml ADDITIONAL INFORMATION tested on vCenter/ESXi 7.0 Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@418b090

govcsim: wait for govcsim to open up port 8080 SUMMARY Wait for 1 second to be sure the service is actually available. ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests Reviewed-by: Abhijeet Kasurde <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a4909c9

tests: disable vmware_guest_instant_clone for now SUMMARY TASK [vmware_guest_instant_clone : Instant Clone a VM with parent VM] ********** task path: /home/zuul/.ansible/collections/ansible_collections/community/vmware/tests/integration/targets/vmware_guest_instant_clone/tasks/main.yml:37 (...) fatal: [testhost]: FAILED! => { "changed": false, "invocation": { "module_args": { "datacenter": "DC0", "datastore": "rw_datastore", "folder": "F0", "guestinfo_vars": [], "host": "esxi1.test", "hostname": "vcenter.test", "moid": null, "name": "cloned_vm_from_vm", "parent_vm": "test_vm1", "password": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER", "port": 443, "proxy_host": null, "proxy_port": null, "resource_pool": "DC0_C0_RP1", "use_instance_uuid": false, "username": "[email protected]", "uuid": null, "validate_certs": false, "vm_password": null, "vm_username": null, "wait_vm_tools": true, "wait_vm_tools_timeout": 300 } }, "msg": "parameters are required together: vm_username, vm_password, guestinfo_vars" } See: https://4305c10cea09eed6be3f-81ad96b319b563f793f006fabfd14100.ssl.cf2.rackcdn.com/957/b66d317ccc58177083f0901caba036c979884246/check/ansible-test-cloud-integration-vcenter7_1esxi-python36_2_of_2/587508e/job-output.txt ISSUE TYPE Bugfix Pull Request This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@1c84eca

tests: remove zuul/vmware/vcenter_1esxi_with_nested Depends-On: ansible/ansible-zuul-jobs#987 Depends-On: #958 SUMMARY We don't make the difference between nested/regular target anymore. ISSUE TYPE Bugfix Pull Request This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ae8bcbb

Revert PR 957 I think that #957 broke the CI pipeline and would like to revert it. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ddcee83

tests: ensure we can create 'VM Network' Depends-On: #961 Depends-On: #967 SUMMARY When we start our tests, VM Network is on vSwitch0. This is configuration is conflicting when we want to create the same portgroup on the isolate_vSwitch0. So far, we avoided the conflict because the teardown_with_esxi.yml playbook was called at the end of the first target and cleaning up the portgroup. This is not the case anymore because: we randomize¹ the target execution order the vmware_cluster_info target does not attach the ESXi host and so the teardown was not working as expected. This commit introduces the following changes: alway clean up VM Network from vSwitch0 before we try to recreate it on the isolated_vSwitch0. move vmware_cluster_info in zuul/vmware/vcenter_only where it belongs e.g: https://9c9a368b55965ac55f2a-ed9c4798e4685666d9a6cb7090f28276.ssl.cf1.rackcdn.com/964/067b5af56b5bda9e4f0542663bbf4560d1899f17/check/ansible-test-cloud-integration-vcenter7_1esxi-python36-stable210_1_of_2/0075174/job-output.txt ¹: well it's a round robin and it remains deterministic ISSUE TYPE Bugfix Pull Request COMPONENT NAME CI Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@0fdaf24

Improve prepare_vmware_tests Depends-on ansible/ansible-zuul-jobs#989 SUMMARY This might cause problems: community.vmware/tests/integration/targets/prepare_vmware_tests/tasks/teardown_with_esxi.yml Lines 90 to 110 in 418b090 - name: Remove ESXi Hosts to vCenter vmware_host: datacenter_name: '{{ dc1 }}' cluster_name: '{{ ccr1 }}' esxi_hostname: '{{ item }}' esxi_username: '{{ esxi_user }}' esxi_password: '{{ esxi_password }}' state: absent with_items: "{{ esxi_hosts }}" ignore_errors: true - name: Exit maintenance on hosts to allow deletion of vCLS VMs vmware_maintenancemode: hostname: "{{ item }}" username: "{{ esxi_user }}" password: "{{ esxi_password }}" esxi_hostname: "{{ item }}" timeout: 3600 state: absent with_items: "{{ esxi_hosts }}" delegate_to: localhost If removing the ESXi host succeeds, exiting maintenance mode fails because the host isn't known to vCenter any more. Fixes #952 ISSUE TYPE Bugfix Pull Request COMPONENT NAME tests/integration/targets/prepare_vmware_tests/tasks/teardown_with_esxi.yml ADDITIONAL INFORMATION Removing all ESXi hosts from the cluster befor removing them from vCenter avoids problems with vCLS VMs. Unfortunatelly, this change broke the vmware_resource_pool integration tests so I had to fix this, too. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@4ceb0cb

Revert "Revert PR 957 (#967)" Depends-On: ansible/ansible-zuul-jobs#1001 Depends-on #971 Re-enable the jobs depending on nested virt. See: ansible/ansible-zuul-jobs#1001 This reverts commit ddcee83. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a8b2d9f

…and enable the test (#962) vmware_guest_instant_clone: Remove the default of the guestinfo_vars and enable the test SUMMARY The cause of the following error occurred is that the default of the guestinfo_vars parameter hadn't been removed. #958 This PR will fix the issue and re-enable the integration test. ISSUE TYPE Bugfix Pull Request COMPONENT NAME changelogs/fragments/962-vmware_guest_instant_clone.yml docs/community.vmware.vmware_guest_instant_clone_module.rst plugins/modules/vmware_guest_instant_clone.py tests/integration/targets/vmware_guest_instant_clone/aliases ADDITIONAL INFORMATION tested on vCenter/ESXi 7.0.2 Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Gonéri Le Bouder <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@04e071c

Add NVDIMM device support in vmware_guest module Signed-off-by: dianew [email protected] SUMMARY create new VM with virtual NVDIMM device add, reconfigure, or remove new NVDIMM device from existing VM Fixes #853 ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c6b96b6

…(#933) vmware_guest: Provide a meaningful message when customization failed Fix result message of PyVmomiHelper.wait_for_customization when it returns failed:True. SUMMARY Added 'msg' to return value when 'wait_for_customization' failed in deploy_vm() Changed 'msg' when 'wait_for_customization' failed in customize_exist_vm() ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/vmware_guest.py ADDITIONAL INFORMATION For every result with result['failed']==True we must have a 'msg' or we get an error while attempting to get it from result dict at end of main() function. Other cases in this module provide 'failed':True with 'msg'. Moreover, current 'msg' for customization existing vm was not correct because wait_for_customization() can return False not only due to timeout but also due to "Customization failed with error {%s}:{%s}". Because of backward compatibility we cannot change its return type from bool to dict and only way to know error message is to see output of module.warn. To reproduce the KeyError while getting 'msg' try to run clone any windows-machine with something like customization: autologon: true autologoncount: 3000 wait_for_customization: yes wait_for_customization_timeout: 60 # little timeout for getting customization error Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a79dbc7

Add a new module vmware_vm_config_option Signed-off-by: dianew [email protected] SUMMARY This module can be used to: get the config options keys list (support for creation hardware versions and default hardware version), get the list of supported guest IDs for specified hardware version or default version, get the basic recommended VM config options for specified guest ID with specified hardware version or default version. Fixes #993 ISSUE TYPE New Module Pull Request COMPONENT NAME vmware_vm_config_option ADDITIONAL INFORMATION TASK [debug] ***************************************************************************************************************************** ok: [localhost] => { "vm_default_config": { "changed": false, "failed": false, "instance": { "Default hardware version": "vmx-14", "Recommended config options": { "Default CDROM controller": "sata", "Default CPU cores per socket": 1, "Default CPU socket": 1, "Default USB controller": "", "Default disk controller": "paravirtual", "Default disk size in MB": 16384, "Default firmware": "bios", "Default memory in MB": 2048, "Default network adapter": "vmxnet3", "Default secure boot": true, "Guest ID": "rhel7_64Guest", "Guest fullname": "Red Hat Enterprise Linux 7 (64-bit)", "Hardware version": "vmx-14", "Support secure boot": true }, "Supported guest IDs for vmx-14": [ "amazonlinux2_64Guest", "windows9Server64Guest", "windows8Server64Guest", "windows7Server64Guest", "winLonghorn64Guest", "winLonghornGuest", "winNetEnterprise64Guest", "winNetEnterpriseGuest", "winNetDatacenter64Guest", "winNetDatacenterGuest", "winNetStandard64Guest", "winNetStandardGuest", "winNetWebGuest", "winNetBusinessGuest", "windows9_64Guest", "windows9Guest", "windows8_64Guest", "windows8Guest", "windows7_64Guest", "windows7Guest", "winVista64Guest", "winVistaGuest", "winXPPro64Guest", "winXPProGuest", "win2000AdvServGuest", "win2000ServGuest", "win2000ProGuest", "winNTGuest", "win98Guest", "win95Guest", "win31Guest", "dosGuest", "vmwarePhoton64Guest", "rhel8_64Guest", "rhel7_64Guest", "rhel6_64Guest", "rhel6Guest", "rhel5_64Guest", "rhel5Guest", "rhel4_64Guest", "rhel4Guest", "rhel3_64Guest", "rhel3Guest", "rhel2Guest", "sles15_64Guest", "sles12_64Guest", "sles11_64Guest", "sles11Guest", "sles10_64Guest", "sles10Guest", "sles64Guest", "slesGuest", "centos8_64Guest", "centos7_64Guest", "centos6_64Guest", "centos6Guest", "centos64Guest", "centosGuest", "debian10_64Guest", "debian10Guest", "debian9_64Guest", "debian9Guest", "debian8_64Guest", "debian8Guest", "debian7_64Guest", "debian7Guest", "debian6_64Guest", "debian6Guest", "debian5_64Guest", "debian5Guest", "debian4_64Guest", "debian4Guest", "opensuse64Guest", "opensuseGuest", "asianux8_64Guest", "asianux7_64Guest", "asianux4_64Guest", "asianux4Guest", "asianux3_64Guest", "asianux3Guest", "fedora64Guest", "fedoraGuest", "oesGuest", "oracleLinux8_64Guest", "oracleLinux7_64Guest", "oracleLinux6_64Guest", "oracleLinux6Guest", "oracleLinux64Guest", "oracleLinuxGuest", "ubuntu64Guest", "ubuntuGuest", "coreos64Guest", "other4xLinux64Guest", "other4xLinuxGuest", "other3xLinux64Guest", "other3xLinuxGuest", "other26xLinux64Guest", "other26xLinuxGuest", "other24xLinux64Guest", "other24xLinuxGuest", "otherLinux64Guest", "otherLinuxGuest", "darwin18_64Guest", "darwin17_64Guest", "darwin16_64Guest", "darwin15_64Guest", "darwin14_64Guest", "darwin13_64Guest", "darwin12_64Guest", "darwin11_64Guest", "darwin11Guest", "darwin10_64Guest", "darwin10Guest", "darwin64Guest", "darwinGuest", "freebsd12_64Guest", "freebsd12Guest", "freebsd11_64Guest", "freebsd11Guest", "freebsd64Guest", "freebsdGuest", "os2Guest", "netware6Guest", "netware5Guest", "solaris11_64Guest", "solaris10_64Guest", "solaris10Guest", "solaris9Guest", "solaris8Guest", "openServer6Guest", "openServer5Guest", "unixWare7Guest", "eComStation2Guest", "eComStationGuest", "otherGuest64", "otherGuest", "vmkernel65Guest", "vmkernel6Guest", "vmkernel5Guest", "vmkernelGuest" ], "Supported hardware versions": [ "vmx-04", "vmx-07", "vmx-08", "vmx-09", "vmx-10", "vmx-11", "vmx-12", "vmx-13", "vmx-14", "vmx-15" ] } } } Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Diane Wang <None> Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: sky-joker <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@3e1a0db

vmware_guest: Update documentation about "Resources" example Document the vmware default resource pool name "Resources" in case this module is used in a loop and must be specified SUMMARY Adds vmware default catch-all resource pool name 'Resources' ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Simplify how vmware handles this variable when undefined (or defined in a loop and operator needs to use the proper default) Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@0ff90d8

vmware_guest_disk/test: use vmx-13 vmware_guest_disk needs vmx-13 to reconfigure the disks. Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@c774313

vmware_guest/tests: drop useless tests Drop: poweroff_d1_c1_f0.yml poweroff_d1_c1_f1.yml Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@2db1c13

test VM should not use more than 1 CPU We don't really need to go above the 1 CPU limit. Our test ESXis come with only 4 CPUS. Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@cdbe9b7

always use debian8_64Guest in our functinal tests The use of the rhel7_64Guest guest_id unlocks some CPU features that we cannot use yet with our CI envionment. The virtualized ESXi won't be able to spawn the nested VM properly. A consequence is the Disconnected from virtual machine. error message. Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@06691c6

vmware_guest/test: reduce network_with_device res usage Do not power on the VM. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@3c2334d

tests: use hw version 11 The ESXis of our CI come with an heterogeneous collection of CPU. The goal is to avoid any dependency with recent CPU features. Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ff3a3aa

tests: use vmware.vmware_rest to clean up the resources Depends-On: ansible/ansible-zuul-jobs#1215 vmware.vmware_rest allow uses to simplify the clean up of the resources and avoid any leaked VM. Also: test VMs use lighter disk size. do not umount the datastore during the teardown. Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@836ba31

tests: remove linked_clone_d1_c1_f0.yml The test does not work and the errors are ignored. Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@7964aff

…ing 'None' (#1025) vmware_guest: fix the Windows Administrator password being set to string 'None' SUMMARY When using Windows VM customization and not specifying a password, the Administrator password is reset to string 'None'. This PR is making the parameter mandatory. This PR is fixing that - when password is not defined, it is cleared (https://vdc-download.vmware.com/vmwb-repository/dcr-public/b50dcbbf-051d-4204-a3e7-e1b618c1e384/538cf2ec-b34f-4bae-a332-3820ef9e7773/vim.vm.customization.GuiUnattended.html). Fixes: #1017 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: Tomas Odehnal <None> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@dcdd4c4

Fix version_added of vmware_guest.advanced_settings SUMMARY The docs for vmware_guest incorrectly state that the advanced_settings parameter was added in 1.7.0. This PR sets the release date to the correct version 1.8.0. ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION The feature was added in #179 as d5d00e3. It did not make it into 1.7.0 but was released as part of 1.8.0, see the release notes. Reviewed-by: Mario Lenz <[email protected]> Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@6668171

vmware_dvs_portgroup: Remove portgroup_type SUMMARY Remove the deprecated parameter portgroup_type. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_dvs_portgroup ADDITIONAL INFORMATION #743 #1071 #1136 Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@4e1234c

vmware_guest: Make VBS requirements explicit SUMMARY #351 made me think about how we handle virtualization based security and I don't like it. I really don't think it's a good idea if modules silently configure something, I think it should always be explicit. ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION #816 Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@2595bdb

tests/govcsim: ignore some broken tests Depends-On: #1194 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@3c4c8e3

Added support for multiple SCSI controllers SUMMARY Fixes #1203 - vmware_guest_storage_policy missing SCSI controller parameter ISSUE TYPE Bugfix Pull Request COMPONENT NAME community.vmware.vmware_guest_storage_policy ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@cad52b7

vmware_guest_powerstate: Use FQCN in examples SUMMARY The examples in vmware_guest_powerstate should use the FQCN. Fixes #1253 ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_guest_powerstate ADDITIONAL INFORMATION Reviewed-by: Abhijeet Kasurde <None> Reviewed-by: sky-joker <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@fd46931

…1280) vmware_guest_powerstate: Ignore trailing slash in folder parameter Depends-On: ansible/ansible-zuul-jobs#1478 SUMMARY Other vmware_guest modules ignore a trailing / in the folder parameter, but vmware_guest_powerstate doesn't. For a consistent user experience, it should do this also. Fixes #1238 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest_powerstate ADDITIONAL INFORMATION As an example, see vmware_guest_snapshot: community.vmware/plugins/modules/vmware_guest_snapshot.py Lines 437 to 440 in fd46931 if module.params['folder']: # FindByInventoryPath() does not require an absolute path # so we should leave the input folder path unmodified module.params['folder'] = module.params['folder'].rstrip('/') This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@5c15e55

Remove vcsim from tests Depends-On: ansible/ansible-zuul-jobs#1489 Remove govcsim from the integration tests. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@d176c43

Remove when: vcsim is not defined from integration tests Depends-On: ansible/ansible-zuul-jobs#1499 Remove when: vcsim is not defined from integration tests. Reviewed-by: Gonéri Le Bouder <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@1dbb975

vmware_guest_move/tests: clean up the f1 directory Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@98cd50d

VCSIM removal part 3 This is a follow-up PR to #1287 and #1288. There's still some VCSIM stuff in the tests. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@3bd4694

VCSIM removal part 4 Depends-On: ansible/ansible-zuul-jobs#1511 SUMMARY This is a follow-up PR to #1293. I wanted to remove VCSIM from the Developer Guide but was asked to move it to the collection (ansible/ansible#77585). I'll start with this and then check if VCSIM mentioned somewhere else in the documentation. ISSUE TYPE Docs Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Sandra McCann <[email protected]> Reviewed-by: Gonéri Le Bouder <[email protected]> Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@9beb329

…375) vmware_guest: Add a supplement description to set network parameters to a guest SUMMARY I add a requirement to set the value of the network parameter to a guest to the module documentation. fixes: #1369 ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/modules/vmware_guest.py ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ff5491d

vmware_guest: change fail to fail_json function Signed-off-by: Diane Wang [email protected] SUMMARY Fixes #1401 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@4df54bc

@felixfontein

…missing license file (#1398) Use SPDX-License-Identifier, mention all licenses in galaxy.yml, add missing license file SUMMARY Implements ansible-community/community-topics#112 (comment). Also adds a missing license file for the BSD-2-Clause licensed vmware_spbm and vmware_rest_client module utils. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME collection ADDITIONAL INFORMATION I've also tried to unify the format. For example, sometimes there was an empty comment before the copyright (# ) and sometimes there was an empty line without a comment. cc @felixfontein Reviewed-by: Felix Fontein <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@19b8ffe

Improve module documentation SUMMARY Python and pyVmomi requirements are already defined at the collection level. So they are, in the best case, redundant in the modules and, in the worst case (mostly, if not always), conflicting. Additionally, all those Tested on documentation is quite misleading. A module might have been tested against a specific vCenter or ESXi version originally, but I assume that in most cases changes to the module weren't. Also, the CI tests run with a version not mentioned in the modules. ISSUE TYPE Docs Pull Request COMPONENT NAME nearly all :-P ADDITIONAL INFORMATION #1412 Reviewed-by: Gonéri Le Bouder <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@b5eb08d

vmware_guest_boot_manager: Add initial integration test SUMMARY There are no integration tests for vmware_guest_boot_manager yet. This PR adds one, although it's still very simple. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_boot_manager ADDITIONAL INFORMATION ansible-collections#28 I'll try to add another one when fixing #1257 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@616dd6e

vmware_guest_boot_manager: Remove secure_boot_enabled default SUMMARY Fixes #1257 When using this module to enable enter_bios_setup on a VM with UEFI and Secure Boot enabled, it will disable Secure Boot. I think the best way to fix this is to not have a default for secure_boot_enabled . ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_boot_manager ADDITIONAL INFORMATION See #1257 for more information. This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@52b308d

vmware_guest_network: Remove deprecated parameter networks SUMMARY Fixes #1195 The networks parameter is deprecated and should be removed. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_network ADDITIONAL INFORMATION community.vmware/plugins/modules/vmware_guest_network.py Lines 865 to 871 in 67b9506 if module.params['networks']: network_data = {} module.deprecate( msg='The old way of configuring interfaces by supplying an arbitrary list will be removed, loops should be used to handle multiple interfaces', version='3.0.0', collection_name='community.vmware' ) This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ce764aa

Remove version_added: 1.x part 1 SUMMARY Now that version 1 is nearly EOL, I don't think that it's important if something has been added in 1.2, 1.4, 1.7 or wherever. ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_guest_storage_policy vmware_guest_tools_wait vmware_guest_tpm vmware_host_custom_attributes vmware_host_datastore vmware_host_iscsi vmware_host_passthrough vmware_host_scanhba vmware_host_snmp vmware_host_sriov vmware_host_tcpip_stacks vmware_object_custom_attributes_info vmware_object_role_permission_info vmware_recommended_datastore vmware_resource_pool vmware_tag_manager vmware_vcenter_settings vmware_vc_infraprofile_info vmware_vm_config_option vmware_vmotion vmware_vm_storage_policy vmware_vsan_health_info ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a83c118

Added scriptText Parameter to execute Scripts in Linux SUMMARY This Commit adds support for the scriptText Parameter. The scriptText Parameter allows to execute any script with a valid shebang. It is used in the VM Customization Specifications for the Customization script https://docs.vmware.com/en/VMware-vSphere/7.0/com.vmware.vsphere.vm_admin.doc/GUID-9A5093A5-C54F-4502-941B-3F9C0F573A39.html ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@39c3101

Fix non-matching defaults in docs SUMMARY Fix various non-matching default values exposed by ansible/ansible#79267. ISSUE TYPE Docs Pull Request COMPONENT NAME vcenter_standard_key_provider vmware_content_library_manager vmware_dvs_host vmware_dvswitch_lacp vmware_dvswitch_nioc vmware_guest vmware_guest_sendkey vmware_host_active_directory vmware_host_snmp ADDITIONAL INFORMATION This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@d1d8d4b

…return value for the diff (#1532) vmware_guest_custom_attributes: Improve the code quality and add the return value for the diff SUMMARY The same function executes when the state is present and absent in vmware_guest_custom_attributes module. I didn't think it was good code, so I refactored the function to split it for each purpose. And added the return value for diff as we can be checked the custom attribute difference. related: #1484 ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/vmware_guest_custom_attributes.py tests/integration/targets/vmware_guest_custom_attributes/tasks/main.yml changelogs/fragments/1532-vmware_guest_custom_attributes.yml ADDITIONAL INFORMATION tested on VCSA 7.0.0 Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@9ed1182

vmware_guest.py - Add CPU/MEM shares support on guest SUMMARY Add support for setting CPU / MEM shares and/or CPU / MEM share-levels Fixes #356 ISSUE TYPE Feature pull request COMPONENT NAME vmware_guest.py ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@65f3456

…cify the boot disk name (#1543) vmware_guest_boot_manager: Add a new parameter 'boot_hdd_name' to specify the boot disk name Signed-off-by: Diane Wang [email protected] SUMMARY For BIOS firmware VM, when add new hard disk to SATA controller, restart VM will result VM disk order changed and VM can not boot up automatically. So in this module, add a new parameter boot_hdd_name to specify boot from which hard disk. Remove the default values of some parameters, if these parameters are not set in the task and previous VM config is not the same as the default value, then these VM config will be changed, which is not expected. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_boot_manager ADDITIONAL INFORMATION - community.vmware.vmware_guest_boot_manager: hostname: xx.xx.xx.xx username: xxxxx password: xxxxx validate_certs: false name: test_vm boot_delay: 20000 enter_bios_setup: false boot_retry_enabled: false boot_retry_delay: 2200 boot_firmware: bios secure_boot_enabled: false boot_order: - disk - cdrom - ethernet boot_hdd_name: 'Hard disk 1' Return results: ok: [localhost] => { "vm_boot_order": { "changed": true, "failed": false, "vm_boot_status": { "current_boot_delay": 20000, "current_boot_disk": "Hard disk 1", "current_boot_firmware": "bios", "current_boot_order": [ "disk", "cdrom", "ethernet" ], "current_boot_retry_delay": 2200, "current_boot_retry_enabled": true, "current_enter_bios_setup": false, "current_secure_boot_enabled": false, "previous_boot_delay": 0, "previous_boot_firmware": "bios", "previous_boot_order": [], "previous_boot_retry_delay": 10000, "previous_boot_retry_enabled": false, "previous_enter_bios_setup": false, "previous_secure_boot_enabled": false } } } Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@490e693

vmware_guest: Add vPMC support SUMMARY Fixes #1511 Add support for virtual performance counters. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION This is a follow-up PR to #1534 that ports the implementation of vPMC to the main branch. Reviewed-by: None <None> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@056fd8b

vmware_guest: Fix check mode SUMMARY Fixes #1272 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION This is a follow-up PR to #1534 that ports the fixes for check mode to the main branch. Reviewed-by: None <None> Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@813d2b6

vmware_guest_network: add support pvrdma network adapter Signed-off-by: Diane Wang [email protected] SUMMARY ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_network ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@260e3bd

vmware_guest_disk: add IDE disk support Signed-off-by: Diane Wang [email protected] SUMMARY We want to use vmware_guest_disk module to add or reconfigure IDE disk on VM. Fixes #1428 Fixes #1617 ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest_disk ADDITIONAL INFORMATION - name: add new ide disk vmware_guest_disk: validate_certs: false hostname: "{{ vcenter_hostname }}" username: "{{ vcenter_username }}" password: "{{ vcenter_password }}" datacenter: "{{ datacenter_name }}" name: test_vm disk: - size_gb: 1 type: thin datastore: Datastore1 state: present controller_type: ide controller_number: 0 unit_number: 1 Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@df3ae15

vmware_guest: fix adding nvdimm device issue on ESXi host SUMMARY Fix the issue of adding new NVDIMM device to VM by connecting to ESXi host. Fixes #1644 ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@68fdad7

Issue1660 2 SUMMARY Follow-up to #1661 ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_host_inventory vmware_vm_inventory vcenter_standard_key_provider vmware_cluster_drs vmware_cluster_ha vmware_cluster_info vmware_cluster_vsan vmware_datacenter_info vmware_datastore_cluster vmware_dvs_portgroup vmware_dvswitch vmware_dvswitch_uplink_pg vmware_guest vmware_guest_boot_manager vmware_guest_disk vmware_guest_file_operation ADDITIONAL INFORMATION #1660 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@6c133cb

Issue 1660 part 3 SUMMARY Follow-up to #1665 ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_vm_inventory vmware_guest_info vmware_guest_instant_clone vmware_guest_powerstate vmware_guest_serial_port vmware_host_facts vmware_host_firewall_manager vmware_host_service_manager vmware_host vmware_portgroup vmware_vm_config_option vmware_vm_host_drs_rule vmware_vmkernel vmware_vm_shell vmware_vm_vm_drs_rule vmware_vsan_health_info vmware_vspan_session vmware_vswitch ADDITIONAL INFORMATION #1660 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@a49559d

Issue 1660 part 5 SUMMARY Follow-up to #1668 ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_dvs_portgroup vmware_guest_disk vmware_guest_file_operation vmware_guest_info vmware_guest_instant_clone vmware_guest_move vmware_guest_network vmware_guest_powerstate vmware_guest vmware_guest_register_operation vmware_guest_serial_port vmware_guest_snapshot_info vmware_guest_snapshot vmware_guest_tools_upgrade vmware_guest_vgpu_info vmware_guest_vgpu vmware_host_acceptance vmware_host_auto_start vmware_host_custom_attributes vmware_host_datastore vmware_host_facts vmware_host_firewall_manager vmware_host_iscsi_info vmware_host_iscsi vmware_host_lockdown_exceptions vmware_host_logbundle_info vmware_host_logbundle vmware_host_ntp vmware_host_passthrough vmware_host_powerstate vmware_host vmware_host_service_manager vmware_host_sriov vmware_local_role_manager vmware_local_user_manager vmware_maintenancemode vmware_migrate_vmk vmware_object_custom_attributes_info vmware_object_rename vmware_object_role_permission_info vmware_object_role_permission vmware_portgroup vmware_recommended_datastore vmware_resource_pool vmware_tag_manager ADDITIONAL INFORMATION #1660 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@fb92ab6

Issue 1660 part 6 SUMMARY Follow-up to #1669 ISSUE TYPE Docs Pull Request COMPONENT NAME various ADDITIONAL INFORMATION #1660 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@8fb7078

vmware_guest - set custom attributes on VM create SUMMARY Fixes issue where custom attributes were not getting set on VM creation. ISSUE TYPE Bugfix Pull Request COMPONENT NAME plugins/modules/vmware_guest.py ADDITIONAL INFORMATION Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ab37851

Update community.vmware.vmware_guest_module.rst Replace missing end of sentence SUMMARY Previous update to the vmware_guest_module cut off end of sentence, losing context and version info. ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_guest_module ADDITIONAL INFORMATION https://docs.ansible.com/ansible/2.9/modules/vmware_guest_module.html Compare the 'folder' parameter between versions 2.9 and the latest. Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@09ccfdf

CI: Remove unnecessary prepare step I think this task is not really necessary: community.vmware/tests/integration/targets/prepare_vmware_tests/tasks/setup_datastore.yml Lines 30 to 32 in f476a07 - vmware_host_scanhba: refresh_storage: true cluster_name: '{{ ccr1 }}' This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@f437f0b

Do not fail when state is absent and disk is not found SUMMARY Fixes #1765. Do not faill when state is absent and disk is not present ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest_disk ADDITIONAL INFORMATION PLAY [localhost] *********************************************************************************************************************************************************************************************************************** TASK [Remove VM disk] ****************************************************************************************************************************************************************************************************************** ok: [localhost] PLAY RECAP ***************************************************************************************************************************************************************************************************************************** localhost : ok=1 changed=0 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0 Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@7658cbe

Also look at NFS mounted datastores, not just VMFS SUMMARY VMware allows datastores to be NFS hosted. Currently the autoselect_datastore logic only considers VMFS filesystems. NFS mounted filesystems show up as "NFS", so adjusting logic to also check and consider those filesystems. ISSUE TYPE Feature Pull Request COMPONENT NAME Make autoselect_datastore consider NFS mounted filesystems. ADDITIONAL INFORMATION Code change does an "or" test on the volume type looking for things that are "NFS" volume types. Validation requires setting up NFS datastores in your ESXi environment, then calling vmware_guest as below: community.vmware.vmware_guest: hostname: "{{ vmware_vcenter }}" username: "{{ vmware_account_name }}" password: "{{ vmware_password }}" validate_certs: False name: "{{ vmware_create_vm_name }}" datacenter: "{{ vmware_datacenter }}" cluster: "{{ vmware_cluster }}" folder: "{{ vmware_folder }}" hardware: num_cpus: "{{ vmware_create_vm_num_cpus }}" memory_mb: "{{ vmware_create_vm_memory_mb }}" disk: - size_gb: "{{ vmware_create_vm_disk_size_gb }}" type: "thick" datastore: "{{ vmware_create_vm_disk_datastore }}" autoselect_datastore: "{{ vmware_create_vm_disk_autoselect_datastore }}" networks: - connected: yes start_connected: yes name: "{{ vmware_create_vm_networks_name }}" cdrom: - type: "iso" controller_number: 0 unit_number: 0 iso_path: "{{ vmware_create_vm_cdrom_iso_path }}" delegate_to: 127.0.0.1 Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@255627d

Implement encryption configuration for vm vmotion and ft SUMMARY Fixes #1069 Implements the ability to configured vm encryption settings for vmotion or fault tolerance ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION Fulfill requirements of #1069 Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@69d0ce7

Fix typo in Docs for vmware_guest module SUMMARY Fix typos ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_guest Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@1a88289

Add snapshot_id option to vmware_guest_snapshot module SUMMARY This PR is to add snapshot_id option to the module. fixes: #1844 ISSUE TYPE Feature Pull Request COMPONENT NAME changelogs/fragments/1847_vmware_guest_snapshot.yml docs/community.vmware.vmware_guest_snapshot_module.rst plugins/modules/vmware_guest_snapshot.py tests/integration/targets/vmware_guest_snapshot/tasks/main.yml ADDITIONAL INFORMATION I will add the integration test in a few days. Done Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@f94611b

vmware_guest: Remove CD-ROM configuration as dict SUMMARY Fixes #1472 Removed specifying CDROM configuration as a dict, instead use a list. ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION #317 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@136556d

Implement semantic markup (4) SUMMARY Implementing semantic markup part 4. ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_drs_group vmware_drs_group_info vmware_drs_group_manager vmware_drs_rule_info vmware_dvs_portgroup vmware_dvs_portgroup_find vmware_dvswitch vmware_dvswitch_info vmware_dvswitch_lacp vmware_dvswitch_nioc vmware_dvswitch_pvlans vmware_evc_mode vmware_export_ovf vmware_folder_info vmware_guest vmware_guest_boot_info vmware_guest_boot_manager vmware_guest_controller vmware_guest_cross_vc_clone vmware_guest_custom_attribute_defs ADDITIONAL INFORMATION #1771 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@4491bf0

Implement semantic markup (5) SUMMARY Implementing semantic markup part 5. ISSUE TYPE Docs Pull Request COMPONENT NAME vmware_guest_custom_attributes vmware_guest_disk vmware_guest_disk_info vmware_guest_file_operation vmware_guest_find vmware_guest_info vmware_guest_instant_clone vmware_guest_move vmware_guest_network vmware_guest_powerstate vmware_guest_register_operation vmware_guest_screenshot vmware_guest_sendkey vmware_guest_serial_port vmware_guest_snapshot vmware_guest_snapshot_info vmware_guest_storage_policy vmware_guest_tools_info vmware_guest_tools_upgrade vmware_guest_tools_wait vmware_guest_tpm vmware_guest_vgpu vmware_guest_vgpu_info vmware_guest_video ADDITIONAL INFORMATION #1771 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@78d6bc1

Fix integration tests SUMMARY Fix integration tests. ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_about_info vmware_category vmware_dvs_portgroup vmware_folder_info vmware_guest_controller vmware_guest_network ADDITIONAL INFORMATION #1937 #1938 This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@515b149

Add IPv6 support for VM network interfaces SUMMARY Add IPv6 support for network interfaces in vmware_guest ISSUE TYPE Feature Pull Request COMPONENT NAME vmware_guest ADDITIONAL INFORMATION The following new parameters are supported in networks section: typev6: optional, either static or dhcp (defaults to static, if ipv6 is given) ipv6: IPv6 address netmaskv6: Length of subnet mask (e.g. 64 for a /64 IPv6 address) gatewayv6: IPv6 address of default gateway Example of Ansible inventory file snippet: hosts: testvm: name: "testvm" network_interfaces: - name: "test" label: "ens192" start_connected: True connected: True ipv6: "fec0:0:0:1::10" netmaskv6: "64" gatewayv6: "fec0:0:0:1::1" Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@ccb14cc

…1848) Fix failure of vm reconfiguration with enabled virt_based_security SUMMARY VM reconfiguration is currently broken when virt_based_security is configured due to checking for vbsEnabled on the wrong object. ISSUE TYPE Bugfix Pull Request COMPONENT NAME vmware_guest Reviewed-by: Mario Lenz <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@6bde749

…ve (#2020) Document that all parameters and VMware object names are case sensitive SUMMARY Fixes #2019 Document that all parameters and VMware object names are case sensitive. ISSUE TYPE Docs Pull Request COMPONENT NAME lots Reviewed-by: Alexander Nikitin <[email protected]> This commit was initially merged in https://github.com/ansible-collections/community.vmware See: ansible-collections/community.vmware@b6080ba

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Promote vmware guest #4

Promote vmware guest #4

Commits on Mar 8, 2024