Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to Stable-3: Fix helm tests (#827) and Fix helm integration tests (#830) #829

Open
wants to merge 4 commits into
base: stable-3
Choose a base branch
from

Conversation

yurnov
Copy link
Contributor

@yurnov yurnov commented Dec 14, 2024

SUMMARY

Some of the charts we've used for testing are no longer available at the old helm repository urls, as they've been moved to oci registries. This updates those charts. In the longer term, we should find a better way to handle these kinds of test fixtures, probably by switching to local charts as much as possible.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey [email protected]
Reviewed-by: Yuriy Novostavskiy

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

This is a backport of PR #830 as merged into main (7559b65).

SUMMARY
Fix charts ref on integration tests targets

ISSUE TYPE
Bugfix Pull Request

SUMMARY

Some of the charts we've used for testing are no longer available at the old helm repository urls, as they've been moved to oci registries. This updates those charts.
In the longer term, we should find a better way to handle these kinds of test fixtures, probably by switching to local charts as much as possible.

ISSUE TYPE

Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Helen Bailey <[email protected]>
Reviewed-by: Yuriy Novostavskiy
@yurnov yurnov mentioned this pull request Dec 14, 2024
Copy link

@abikouo abikouo added the test-all-the-targets In order to tell to the integration test splitter to test all targets label Dec 16, 2024
Copy link

commit was created for the testing purposes and should not be merged

This reverts commit 1379e77.
Copy link

SUMMARY
Fix charts ref on integration tests targets
ISSUE TYPE


Bugfix Pull Request

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Alina Buzachis
@yurnov yurnov changed the title Backport to Stable-3: Fix helm tests (#827) Backport to Stable-3: Fix helm tests (#827) and Fix helm integration tests (#830) Dec 18, 2024
@yurnov
Copy link
Contributor Author

yurnov commented Dec 18, 2024

Added second PR (#830), so, currently it's cherry-picked of #827 and #830. Reason: in the cherry-pick of single PR (this one or #832 as backport of #830) we have failed CI

Copy link

@yurnov
Copy link
Contributor Author

yurnov commented Dec 19, 2024

Hi @abikouo, could you please approve this PR? It's a backport of CI fix and the reason for manual PR is that the bot did not create a backport of #827 due to conflicts even though the backport-3 label was given. No any code besides that.

@yurnov yurnov mentioned this pull request Dec 26, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-all-the-targets In order to tell to the integration test splitter to test all targets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants