stable-4.x: vmware_vmotion: Catch no placement recommendation

[mariolenz]

SUMMARY

Backport of #2208

I think there's a problem here:

community.vmware/plugins/modules/vmware_vmotion.py

Lines 481 to 484 in 7c2cc76

	if self.host_object is None:
	self.host_object = placement.recommendations[0].action[0].targetHost
	if self.datastore_object is None:
	self.datastore_object = placement.recommendations[0].action[0].relocateSpec.datastore

If vSphere doesn't give a recommendation, this might result in a list index out of range error.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

vmware_vmotion

ADDITIONAL INFORMATION

#2209

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/c1f649ad06f04f9e973ab36529526f43

✔️ ansible-tox-linters SUCCESS in 4m 24s
✔️ build-ansible-collection SUCCESS in 8m 14s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 FAILURE in 13m 44s
✔️ ansible-galaxy-importer SUCCESS in 5m 06s

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/29c5bf0d18794682be032d65bfb58712

✔️ ansible-tox-linters SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 7m 36s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 FAILURE in 12m 02s
✔️ ansible-galaxy-importer SUCCESS in 12m 48s

[mariolenz]

recheck

[softwarefactory-project-zuul]

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/62d32aecc9ad43a8a1e0e4a75583fa15

✔️ ansible-tox-linters SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 7m 41s
✔️ ansible-test-cloud-integration-vcenter7_only-stable217 SUCCESS in 20m 27s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable217 SUCCESS in 17m 18s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_1_of_2 SUCCESS in 1h 06m 30s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable217_2_of_2 SUCCESS in 1h 03m 37s
✔️ ansible-galaxy-importer SUCCESS in 5m 09s

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/3c80e9f7372f4558a96a60a6b757a25f

✔️ ansible-tox-linters SUCCESS in 4m 36s
✔️ build-ansible-collection SUCCESS in 5m 52s
✔️ ansible-galaxy-importer SUCCESS in 4m 07s