Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support regexp for datastore autoselect #2038

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ephracis
Copy link

@ephracis ephracis commented Apr 3, 2024

SUMMARY

When automatically selecting a datastore, use regular expression instead of a simple string search.

This will increase the utility of the autoselect feature to support use cases such as when the user wants to select

datastores matching '_MyTeam_' but without the prefix 'DoNotUse_'.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

This is backwards compatible for simple strings, and since there are limits on special characters allowed in datastore names I believe there shouldn't be any cases where users would need to adjust their input because of this change.

When automatically selecting a datastore, use regular expression instead of a simple string
search as this will support additional use cases such as when there are datastores with the
prefix "DoNotUse_" which should not be selected automatically.
@alinabuzachis
Copy link
Contributor

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants