Support regexp for datastore autoselect #2038
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When automatically selecting a datastore, use regular expression instead of a simple string search.
This will increase the utility of the autoselect feature to support use cases such as when the user wants to select
ISSUE TYPE
COMPONENT NAME
vmware_guest
ADDITIONAL INFORMATION
This is backwards compatible for simple strings, and since there are limits on special characters allowed in datastore names I believe there shouldn't be any cases where users would need to adjust their input because of this change.