Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add feature to allow template username and password on inventory #1837

Merged
merged 6 commits into from
Sep 12, 2023
Merged

feat: add feature to allow template username and password on inventory #1837

merged 6 commits into from
Sep 12, 2023

Conversation

paulojmdias
Copy link
Contributor

@paulojmdias paulojmdias commented Sep 6, 2023 •
edited
Loading

SUMMARY
  • This enables using of Jinja2 for templating username and password
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • community.vmware.vmware_vm_inventory
  • community.vmware.vmware_host_inventory
ADDITIONAL INFORMATION
  • Currently, the username and password can be set by Environment Variables, plain or using Ansible Vault. In an inventory using LDAP credentials, with multiple environments and consequently LDAP servers, it's a pain to manage those credentials in a safer way and at the same time dynamically. Also if someone is not using Ansible Vault, allows usage of different ways for storing those secrets safely. Supporting Jinja2, allows anyone to use different lookup plugins that best fit their needs.

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ef6f657bda574ae58f085e0466c3b840

❌ ansible-tox-linters FAILURE in 8m 24s
⚠️ build-ansible-collection CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
⚠️ ansible-galaxy-importer CANCELED

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/da2341901f224e258ed169eb85736786

✔️ ansible-tox-linters SUCCESS in 8m 23s
✔️ build-ansible-collection SUCCESS in 9m 17s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 21m 42s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 15s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 51m 00s
✔️ ansible-galaxy-importer SUCCESS in 4m 25s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4d3e33b421b34844a129ae772603b96f

⚠️ ansible-tox-linters CANCELED
❌ build-ansible-collection FAILURE in 7m 52s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/99b514a8e527429aa3903cc6dd4e918a

✔️ ansible-tox-linters SUCCESS in 8m 37s
✔️ build-ansible-collection SUCCESS in 9m 32s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 39s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 40m 44s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 51s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7b1199c88fb44fdea7e6294bda4e5267

✔️ ansible-tox-linters SUCCESS in 8m 29s
✔️ build-ansible-collection SUCCESS in 9m 20s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 21m 38s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 34m 57s
✔️ ansible-galaxy-importer SUCCESS in 4m 54s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/12ba64cc80e14e45bbbe773ae1a0373a

✔️ ansible-tox-linters SUCCESS in 8m 28s
✔️ build-ansible-collection SUCCESS in 9m 43s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 29s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 35m 03s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 4m 58s

@paulojmdias
Copy link
Contributor Author

@mariolenz could you please help me understand why tests are failing?

The error is weird, something is wrong with the service Failed to create a virtual machine : There are no active hosts in the cluster..

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/7abb3524684d461ea3011c12c3eb4854

✔️ ansible-tox-linters SUCCESS in 8m 29s
✔️ build-ansible-collection SUCCESS in 9m 26s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 17m 23s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 34s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e50b86f15c854b038ca217a976d750dc

✔️ ansible-tox-linters SUCCESS in 8m 42s
✔️ build-ansible-collection SUCCESS in 9m 44s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 17m 37s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 33m 53s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 15s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6388687e5f034d9d95133ab18c134472

✔️ ansible-tox-linters SUCCESS in 8m 31s
✔️ build-ansible-collection SUCCESS in 9m 24s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 44m 02s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 CANCELED
✔️ ansible-galaxy-importer SUCCESS in 5m 22s

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/cde1dff5720e46c8bd2c00795d04942c

✔️ ansible-tox-linters SUCCESS in 8m 32s
✔️ build-ansible-collection SUCCESS in 9m 33s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
❌ ansible-test-cloud-integration-vcenter7_2esxi-stable215 FAILURE in 16m 24s
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 57m 29s
✔️ ansible-galaxy-importer SUCCESS in 4m 19s

@ihumster
Copy link
Collaborator

ihumster commented Sep 8, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/43d59171ad5949ae80c371c7246ecfea

✔️ ansible-tox-linters SUCCESS in 8m 30s
✔️ build-ansible-collection SUCCESS in 9m 22s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 14m 30s
✔️ ansible-galaxy-importer SUCCESS in 5m 48s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ac6415cb26f04d87804780061218a7f9

✔️ ansible-tox-linters SUCCESS in 8m 50s
✔️ build-ansible-collection SUCCESS in 9m 33s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 13s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 FAILURE in 44m 24s
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006371871 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 5m 01s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/508161ccc8134beab0f2a4a58a044a56

✔️ ansible-tox-linters SUCCESS in 9m 29s
✔️ build-ansible-collection SUCCESS in 9m 31s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 18m 23s
✔️ ansible-galaxy-importer SUCCESS in 4m 52s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4b60d96212f94fdd9de7605c3f327997

✔️ ansible-tox-linters SUCCESS in 8m 40s
✔️ build-ansible-collection SUCCESS in 9m 45s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 19m 01s
✔️ ansible-galaxy-importer SUCCESS in 4m 21s

@paulojmdias
Copy link
Contributor Author

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/22720ef7304b425fbc35d9502d9c2b29

✔️ ansible-tox-linters SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 9m 33s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 24s
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 CANCELED
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 CANCELED
❌ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 FAILURE in 38m 16s
✔️ ansible-galaxy-importer SUCCESS in 4m 12s

@paulojmdias
Copy link
Contributor Author

@ihumster could you please help me understand why tests are failing?

@mariolenz
Copy link
Collaborator

@paulojmdias At least the last three failures look like there's some weird problem in the CI pipeline itself to me... again 😫

@paulojmdias
Copy link
Contributor Author

@paulojmdias At least the last three failures look like there's some weird problem in the CI pipeline itself to me... again 😫

😢 Can I help in some way?

@ihumster
Copy link
Collaborator

Nope. Only recheck and catch your luck.

@ihumster
Copy link
Collaborator

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/657c23e9009748f09064a431db555c92

✔️ ansible-tox-linters SUCCESS in 8m 35s
✔️ build-ansible-collection SUCCESS in 9m 26s
✔️ ansible-test-cloud-integration-vcenter7_only-stable215 SUCCESS in 22m 20s
✔️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SUCCESS in 20m 28s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SUCCESS in 49m 17s
✔️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SUCCESS in 57m 19s
✔️ ansible-galaxy-importer SUCCESS in 4m 57s

@ihumster
Copy link
Collaborator

Nice. I'm lacker =)

@mariolenz If you have no questions about the code (I don’t seem to have any), then you can probably approve this merge.

@paulojmdias
Copy link
Contributor Author

Thank you @ihumster. 🙏

If you have any questions please let me know @mariolenz.

mariolenz
mariolenz approved these changes Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @paulojmdias!

@ihumster could you please test if you can approve? And maybe try to add the merge label.

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c567a66d77294484aa9899445a14410e

✔️ ansible-tox-linters SUCCESS in 8m 54s
✔️ build-ansible-collection SUCCESS in 7m 49s
✔️ ansible-galaxy-importer SUCCESS in 3m 26s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 3530e1c into ansible-collections:main Sep 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulojmdias @ihumster @mariolenz