Added module for managing password expiration for root user #1833
Conversation
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 46s |
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 58s |
|
@valentinJonev Hello, Valentin. For work with vcenter rest api community.vmware modules use module_utils.vmware_rest_client. It would be nice to stick to common patterns when building the modules of this collection. See how vmware_content_library_manager.py is built for an example. |
|
I'm not sure if vmware.vmware_rest is a good place to to implement new features:
Actually, I was thinking about taking over this collection- that is moving the modules to BTW I think some modules already use the REST API because they provide features the SOAP API doesn't support. cc @jillr |
|
@mariolenz Mario, I did not mean the vmware.vmware_rest collection (by the way, it is built using another project - ansible_content_builder). I'm talking about the fact that in this collection, work with rest methods is implemented by the general VmwareRestClient class from module_utils/vmware_rest_client.py |
|
@ihumster Sorry, you're right. Of course, using |
@mariolenz Can we help you with understanding or better documenting what the generator is doing, or how it's designed? We would be happy to take contributions to that collection. (You can certainly fork the modules, but it would be nice to have any fixes or new features for the modules all in one place.) |
|
@ihumster I updated the module to use the API client from the module_utils.vmware_rest_client. If you have further suggestions, please let me know |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 36s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 39s |
I think this is a bit off-topic here. I've created ansible-collections/vmware.vmware_rest#423 to discuss this. cc @ihumster in case you're interested |
|
Any idea why the build is failing? |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 28s |
|
Checks pass, so should be ready for merging? |
Co-authored-by: Mario Lenz <[email protected]>
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 45s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 35s |
|
Ok, but why are the checks failing without a useful message? |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 28s |
|
@mariolenz the build is failing because there is a problem in the code (or so I think) Last time the build failed and then the GitHub checks were ran I saw a couple of things the sanity check was complaining, I fixed them and then he build succeeded. |
Co-authored-by: Mario Lenz <[email protected]>
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 30s |
|
recheck |
|
@valentinJonev It looks like the sanity tests succeed now 😄 The integration tests still have a problem. But there are no integration tests using your code (yet), so this has to be some problem in the CI pipeline and not with your code. |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 35s |
|
recheck |
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 8m 36s |
There was a problem hiding this comment.
Not really sure about everything, but let's merge it now that the CI succeeded.
Thanks @valentinJonev and also thanks for your patience!
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 8m 27s |
softwarefactory-project-zuul
bot
merged commit c7b1f59
into
ansible-collections:main
SUMMARY
Added a new module for managing password expiration for root user of vCSA appliance
ISSUE TYPE
COMPONENT NAME
vcenter_root_password_expiration
ADDITIONAL INFORMATION