-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoselect datastore use regex #1756
Autoselect datastore use regex #1756
Conversation
Build failed.
|
Hi, just checking on this PR, is this pending me for something? Sorry, I'm new to these builds so I will probably need a bit more direction if there's more I need to do. For what it's worth the above code is working fine for me, and the magnitude of change I was suspecting wouldn't run afoul of any linting. |
recheck |
Build failed.
|
recheck |
Build failed.
|
recheck |
Build failed.
|
Build failed. ❌ ansible-tox-linters FAILURE in 8m 40s |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 48s |
recheck |
1 similar comment
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 35s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 58s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 49s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 59s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 47s |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 43s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 59s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 51s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 37s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 10m 09s |
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 49s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 45s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 41s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 39s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 57s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 44s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 27s |
Having a hard time with the building, possibly related to issue #1746 and lack of Red Hat support for the build system. |
@nikatbu I've already pinged people about the |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 44s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 34s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 56s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 8m 33s |
recheck |
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 00s |
recheck |
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 03s |
SUMMARY
When finding the datastore(s) with autoselect_datastore, using re.search() provides more flexibility to match above what .find() substring matching can do.
ISSUE TYPE
COMPONENT NAME
vmware_guest.py autoselect_datastore functionality
ADDITIONAL INFORMATION
Swapped call ds.name.find() over to using re.search() to provide regex searching ability.