Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoselect datastore use regex #1756

Closed
wants to merge 0 commits into from
Closed

Autoselect datastore use regex #1756

wants to merge 0 commits into from

Conversation

nikatbu
Copy link
Contributor

@nikatbu nikatbu commented May 31, 2023

SUMMARY

When finding the datastore(s) with autoselect_datastore, using re.search() provides more flexibility to match above what .find() substring matching can do.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest.py autoselect_datastore functionality

ADDITIONAL INFORMATION

Swapped call ds.name.find() over to using re.search() to provide regex searching ability.


- name: Create a virtual machine on given ESXi hostname
  community.vmware.vmware_guest:
[...]
    disk:
    - size_gb: 10
      type: thin
      datastore: datastore1_SSD
      autoselect_datastore: True
[...]

- name: Create a virtual machine on given ESXi hostname
  community.vmware.vmware_guest:
[...]
    disk:
    - size_gb: 10
      type: thin
      datastore: '_SSD$'
      autoselect_datastore: True
[...]


@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ff4bfad80acd458990a33690b24442d6

⚠️ ansible-tox-linters CANCELED
build-ansible-collection FAILURE in 5m 56s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable214 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable214 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable214_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 23, 2023

Hi, just checking on this PR, is this pending me for something? Sorry, I'm new to these builds so I will probably need a bit more direction if there's more I need to do. For what it's worth the above code is working fine for me, and the magnitude of change I was suspecting wouldn't run afoul of any linting.

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 26, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1d856f215d484e549633083bcbeb67c4

⚠️ ansible-tox-linters CANCELED
build-ansible-collection FAILURE in 6m 31s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 26, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/a5aa8d5ea6284c4eb2ef6ecaa02552ea

⚠️ ansible-tox-linters CANCELED
build-ansible-collection FAILURE in 6m 56s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 26, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9fd98e4d7c2b464fa6c496b066273a84

⚠️ ansible-tox-linters CANCELED
build-ansible-collection FAILURE in 6m 00s
⚠️ ansible-test-cloud-integration-vcenter7_only-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_2esxi-stable215 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 SKIPPED Skipped due to failed job build-ansible-collection
⚠️ ansible-galaxy-importer SKIPPED Skipped due to failed job build-ansible-collection

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 26, 2023

recheck

1 similar comment
@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 26, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 26, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 27, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 27, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 27, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 27, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 27, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 27, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 27, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 28, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 29, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 29, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jun 29, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jul 5, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jul 6, 2023

recheck

@nikatbu
Copy link
Contributor Author

nikatbu commented Jul 6, 2023

Having a hard time with the building, possibly related to issue #1746 and lack of Red Hat support for the build system.

@mariolenz
Copy link
Collaborator

@nikatbu I've already pinged people about the License not available to perform the operation issue and I think they're already working on it.

@jillr
Copy link
Contributor

jillr commented Jul 6, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2d2d5ab0872b4332974a14fdb3ad5230

✔️ ansible-tox-linters SUCCESS in 8m 44s
✔️ build-ansible-collection SUCCESS in 9m 16s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006179223 failed in 0s
ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006179224 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006179225 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006179226 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 40s

@jillr
Copy link
Contributor

jillr commented Jul 6, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4a38f7fad29b4b81b6207d3aeef1e29c

✔️ ansible-tox-linters SUCCESS in 8m 34s
✔️ build-ansible-collection SUCCESS in 9m 20s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006179254 failed in 0s
ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006179255 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006179256 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006179257 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 3m 45s

@jillr
Copy link
Contributor

jillr commented Jul 6, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5cdc6b96f40349819c95a6deb07d98c4

✔️ ansible-tox-linters SUCCESS in 8m 56s
✔️ build-ansible-collection SUCCESS in 9m 16s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006179352 failed in 0s
ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006179353 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006179354 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006179355 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 3m 47s

@jillr
Copy link
Contributor

jillr commented Jul 7, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/d62f4696dd9e486584060e2640c8aa13

✔️ ansible-tox-linters SUCCESS in 8m 33s
✔️ build-ansible-collection SUCCESS in 9m 16s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006182200 failed in 0s
ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006182201 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006182202 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006182203 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 01s

@jillr
Copy link
Contributor

jillr commented Jul 12, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4e8bc35be38e4ad0af0343267c320365

✔️ ansible-tox-linters SUCCESS in 9m 00s
✔️ build-ansible-collection SUCCESS in 9m 40s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006195699 failed in 0s
ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006195700 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006195701 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006195702 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 4m 41s

@nikatbu
Copy link
Contributor Author

nikatbu commented Jul 13, 2023

recheck

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/ansible-collections/community.vmware for 1756,97a9cc626b3abc5a676e563688269a195dbe27da

@nikatbu nikatbu closed this Jul 13, 2023
@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/01ad0c88ba714838bf66ce67a97b57ec

✔️ ansible-tox-linters SUCCESS in 9m 03s
✔️ build-ansible-collection SUCCESS in 9m 33s
ansible-test-cloud-integration-vcenter7_only-stable215 NODE_FAILURE Node request 200-0006198692 failed in 0s
ansible-test-cloud-integration-vcenter7_2esxi-stable215 NODE_FAILURE Node request 200-0006198693 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_1_of_2 NODE_FAILURE Node request 200-0006198694 failed in 0s
ansible-test-cloud-integration-vcenter7_1esxi-stable215_2_of_2 NODE_FAILURE Node request 200-0006198695 failed in 0s
✔️ ansible-galaxy-importer SUCCESS in 5m 58s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants