lookup plugins: use f-strings

[russoz]

SUMMARY

Use f-strings instead of string interpolations or string format().

ISSUE TYPE

• Refactoring Pull Request

COMPONENT NAME

plugins/lookup/bitwarden.py
plugins/lookup/chef_databag.py
plugins/lookup/collection_version.py
plugins/lookup/consul_kv.py
plugins/lookup/credstash.py
plugins/lookup/cyberarkpassword.py
plugins/lookup/dependent.py
plugins/lookup/dig.py
plugins/lookup/dnstxt.py
plugins/lookup/dsv.py
plugins/lookup/etcd.py
plugins/lookup/etcd3.py
plugins/lookup/filetree.py
plugins/lookup/github_app_access_token.py
plugins/lookup/hiera.py
plugins/lookup/keyring.py
plugins/lookup/lastpass.py
plugins/lookup/lmdb_kv.py
plugins/lookup/manifold.py
plugins/lookup/merge_variables.py
plugins/lookup/onepassword.py
plugins/lookup/onepassword_doc.py
plugins/lookup/passwordstore.py
plugins/lookup/random_pet.py
plugins/lookup/redis.py
plugins/lookup/revbitspss.py
plugins/lookup/shelvefile.py
plugins/lookup/tss.py

[ansibullbot]

cc @Akasurde @None @RevBits @alpex8 @azenk @dagwieers @delineaKrehl @eric-belhomme @felixfontein @galanoff @jparrill @jpmens @lungj @m-a-r-k-e @rlenferink @samdoran @tylerezimmerman @weisheng-p
click here for bot help

[russoz]

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

plugins/lookup/dependent.py:188:0: unidiomatic-typecheck: Type comparison using type() found. Use isinstance() instead
plugins/lookup/dependent.py:217:0: unidiomatic-typecheck: Type comparison using type() found. Use isinstance() instead

click here for bot help

@felixfontein this looks like a snafu from validate-modules to me. There is no type comparison happening in those lines. Should I just add an ignore file for the file or do you want to adjust something in the validation?

[felixfontein]

@felixfontein this looks like a snafu from validate-modules to me. There is no type comparison happening in those lines. Should I just add an ignore file for the file or do you want to adjust something in the validation?

For now it's best to add ignore.txt entries. The check has been removed from ansible-core 2.17 anyway, so fixing it is no longer possible.

[felixfontein]

(Ref: ansible/ansible@9dd3eaf)

[felixfontein]

Here again the opening and ending sequence is part of the formatting string, which was intentionally not the case before. How about reverting to the original code?

Suggested change

	expression = '{{%s}}' % expression
	expression = "{0}{1}{2}".format("{{", expression, "}}")

Using format() is still totally legal and fine.