proxmox_disk: fix async method of resize_disk

[castorsky]

SUMMARY

This PR closes issue #9254 which was based on PR #7969.
Method for resizing disk is now aware of using asyncronous API PUT endpoint and correctly handles messages about errors.

Note: compatibility with Proxmox VE version < 8.0.0 was broken since the API was changed upstream.

Additionally, I made a brief refactoring of methods in proxmox_disk module and added one new method to the proxmox module utility (api_task_complete). This method expands the api_task_ok method in terms of errors and timeout handling - it waits for task to complete and returns an error message if task was completed but not succesful.

ISSUE TYPE

• Bugfix Pull Request
• Refactoring Pull Request

COMPONENT NAME

proxmox_disk

ADDITIONAL INFORMATION

[ansibullbot]

cc @Ajpantuso @Thulium-Drake @UnderGreen @joshainglis @karmab @krauthosting
click here for bot help

[russoz]

Hi @castorsky thanks for your contribution!

Just two tiny adjustments in the changelog fragment formatting and we should be good to go.

[russoz]

LGTM

[felixfontein]

Hmm, does

Note: compatibility with Proxmox VE version < 8.0.0 was broken since the API was changed upstream.

mean that this PR is backwards incompatible with versions of Proxmox where this module works fine? If that's the case, then the fix needs to be adjusted so it still works fine with older versions.

[castorsky]

this PR is backwards incompatible with versions of Proxmox where this module works fine

Hi, @felixfontein! Yes, this is the case which was discussed in #9199 and which still has no clear answer. Should we support old PVE versions that were abandoned by upstream? IMO supporting of legacy unsupported version should be maintained by users of said versions themselves.

I have a workaround, but I still think that this leads to module bloat.

[felixfontein]

Hi, @felixfontein! Yes, this is the case which was discussed in #9199 and which still has no clear answer. Should we support old PVE versions that were abandoned by upstream? IMO supporting of legacy unsupported version should be maintained by users of said versions themselves.

There has been an answer to that: #9199 (comment)

As long as we do not explicitly drop support for versions we currently support (even if they have been EOLed for a long time), we have to keep support for them working. To change that we have to explicitly deprecate support and only drop it in a new major release. So for future versions we might not need to support older Proxmox versions, but for current versions we must.