Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_ini: add allow_no_value #9160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

to_ini: add allow_no_value #9160

wants to merge 1 commit into from

Conversation

pboesch
Copy link

@pboesch pboesch commented Nov 20, 2024

SUMMARY

Add allow_no_value=True to to_ini filter like for ini_file module. Some configuration files are known to include settings without values like mysql.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

to_ini

@ansibullbot
Copy link
Collaborator

cc @sscheib
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request filter filter plugin new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Nov 20, 2024
@sscheib
Copy link
Contributor

sscheib commented Nov 20, 2024

Thanks @pboesch for creating this PR. Are you able to add test coverage for this? If not I can co-author it myself sometime this week.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Nov 20, 2024
@felixfontein
Copy link
Collaborator

Thanks for your contribution! Please also add a changelog fragment. Thanks!

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. feature This issue/PR relates to a feature request filter filter plugin new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pboesch @ansibullbot @sscheib @felixfontein