zypper_repository: extend module with possibility to modify repos

[computersalat]

SUMMARY

Extend module to also modify (zypper mr) repos.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

zypper_repository

ADDITIONAL INFORMATION

I missed the possibility to modify (zypper mr) existing repositories like enable or disable. I didn't like the add and remove only approach because I created the repo files via templates with my own naming scheme.
Especially when you want to do a zypper dup you need to add the new repos enabled while disabling current repos.
This extension gives the user more possibilies to use this module.

[ansibullbot]

cc @AnderEnder @alxgu @andytom @commel @evrardjp @lrupp @sealor @toabctl
click here for bot help

[felixfontein]

Thanks for your contribution!

[felixfontein]

Please note that module options such as action are not a good idea (https://docs.ansible.com/ansible/devel/dev_guide/developing_modules_best_practices.html#designing-module-interfaces), in particular if state is already present.

All your actions should already be doable with state. Modifying should be done with state=present and passing other parameters.

[computersalat]

I hear you, but state with [ "absent", "present" ] is only relevant when using add or remove, but it's irrelevant when using action with [ "modify" ]. When I modify a repo I expect it to be present.
Introducing action was IMHO the only possibility to add feature: modify.
If you have a better idea, I am open to hear ...

[felixfontein]

No, state=present usually also means modify (except in certain situations, like it hasn't been implemented yet).

Please remove the action option and change the code so that with state=present it creates (if it doesn't exist yet) or modifies (if it does exist and is changed).

[felixfontein]

@computersalat ping

needs_info

[ansibullbot]

@computersalat This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help