Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nmcli): remove bond from ip_conn_type #8729

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

fix(nmcli): remove bond from ip_conn_type

e82c8f7
Select commit
Loading
Failed to load commit list.
Draft

fix(nmcli): remove bond from ip_conn_type #8729

fix(nmcli): remove bond from ip_conn_type
e82c8f7
Select commit
Loading
Failed to load commit list.
Azure Pipelines / CI failed Aug 7, 2024 in 5m 50s

Build #20240807.20 had test failures

Details

Tests

  • Failed: 13 (0.64%)
  • Passed: 2,003 (98.38%)
  • Other: 20 (0.98%)
  • Total: 2,036

Annotations

Check failure on line 791 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L791

Bash exited with code '1'.

Check failure on line 763 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L763

Bash exited with code '1'.

Check failure on line 749 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L749

Bash exited with code '1'.

Check failure on line 751 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

Build log #L751

Bash exited with code '1'.

Check failure on line 1 in test_bond_connection_create[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_bond_connection_create[patch_ansible_module0]

AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]
Raw output
mocked_generic_connection_create = None
capfd = <_pytest.capture.CaptureFixture object at 0x793362ccc5c0>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_BOND, indirect=['patch_ansible_module'])
    def test_bond_connection_create(mocked_generic_connection_create, capfd):
        """
        Test : Bond connection created
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        assert nmcli.Nmcli.execute_command.call_count == 1
        arg_list = nmcli.Nmcli.execute_command.call_args_list
        args, kwargs = arg_list[0]
    
        assert args[0][0] == '/usr/bin/nmcli'
        assert args[0][1] == 'con'
        assert args[0][2] == 'add'
        assert args[0][3] == 'type'
        assert args[0][4] == 'bond'
        assert args[0][5] == 'con-name'
        assert args[0][6] == 'non_existent_nw_device'
    
        for param in ['ipv4.gateway', 'primary', 'connection.autoconnect',
                      'connection.interface-name', 'bond_non_existant',
                      'mode', 'active-backup', 'ipv4.addresses',
                      '+bond.options', 'xmit_hash_policy=layer3+4']:
>           assert param in args[0]
E           AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]

tests/unit/plugins/modules/test_nmcli.py:2034: AssertionError

Check failure on line 1 in test_bond_connection_create[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_bond_connection_create[patch_ansible_module0]

AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]
Raw output
mocked_generic_connection_create = None
capfd = <_pytest.capture.CaptureFixture object at 0x708baf90acd0>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_BOND, indirect=['patch_ansible_module'])
    def test_bond_connection_create(mocked_generic_connection_create, capfd):
        """
        Test : Bond connection created
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        assert nmcli.Nmcli.execute_command.call_count == 1
        arg_list = nmcli.Nmcli.execute_command.call_args_list
        args, kwargs = arg_list[0]
    
        assert args[0][0] == '/usr/bin/nmcli'
        assert args[0][1] == 'con'
        assert args[0][2] == 'add'
        assert args[0][3] == 'type'
        assert args[0][4] == 'bond'
        assert args[0][5] == 'con-name'
        assert args[0][6] == 'non_existent_nw_device'
    
        for param in ['ipv4.gateway', 'primary', 'connection.autoconnect',
                      'connection.interface-name', 'bond_non_existant',
                      'mode', 'active-backup', 'ipv4.addresses',
                      '+bond.options', 'xmit_hash_policy=layer3+4']:
>           assert param in args[0]
E           AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]

tests/unit/plugins/modules/test_nmcli.py:2034: AssertionError

Check failure on line 1 in test_bond_connection_create[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_bond_connection_create[patch_ansible_module0]

AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]
Raw output
mocked_generic_connection_create = None
capfd = <_pytest.capture.CaptureFixture object at 0x7a3d97504390>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_BOND, indirect=['patch_ansible_module'])
    def test_bond_connection_create(mocked_generic_connection_create, capfd):
        """
        Test : Bond connection created
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        assert nmcli.Nmcli.execute_command.call_count == 1
        arg_list = nmcli.Nmcli.execute_command.call_args_list
        args, kwargs = arg_list[0]
    
        assert args[0][0] == '/usr/bin/nmcli'
        assert args[0][1] == 'con'
        assert args[0][2] == 'add'
        assert args[0][3] == 'type'
        assert args[0][4] == 'bond'
        assert args[0][5] == 'con-name'
        assert args[0][6] == 'non_existent_nw_device'
    
        for param in ['ipv4.gateway', 'primary', 'connection.autoconnect',
                      'connection.interface-name', 'bond_non_existant',
                      'mode', 'active-backup', 'ipv4.addresses',
                      '+bond.options', 'xmit_hash_policy=layer3+4']:
>           assert param in args[0]
E           AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]

tests/unit/plugins/modules/test_nmcli.py:2034: AssertionError

Check failure on line 1 in test_bond_connection_create[patch_ansible_module0]

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI

test_bond_connection_create[patch_ansible_module0]

AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]
Raw output
mocked_generic_connection_create = None
capfd = <_pytest.capture.CaptureFixture object at 0x7aee96b9f630>

    @pytest.mark.parametrize('patch_ansible_module', TESTCASE_BOND, indirect=['patch_ansible_module'])
    def test_bond_connection_create(mocked_generic_connection_create, capfd):
        """
        Test : Bond connection created
        """
        with pytest.raises(SystemExit):
            nmcli.main()
    
        assert nmcli.Nmcli.execute_command.call_count == 1
        arg_list = nmcli.Nmcli.execute_command.call_args_list
        args, kwargs = arg_list[0]
    
        assert args[0][0] == '/usr/bin/nmcli'
        assert args[0][1] == 'con'
        assert args[0][2] == 'add'
        assert args[0][3] == 'type'
        assert args[0][4] == 'bond'
        assert args[0][5] == 'con-name'
        assert args[0][6] == 'non_existent_nw_device'
    
        for param in ['ipv4.gateway', 'primary', 'connection.autoconnect',
                      'connection.interface-name', 'bond_non_existant',
                      'mode', 'active-backup', 'ipv4.addresses',
                      '+bond.options', 'xmit_hash_policy=layer3+4']:
>           assert param in args[0]
E           AssertionError: assert 'ipv4.gateway' in ['/usr/bin/nmcli', 'con', 'add', 'type', 'bond', 'con-name', ...]

tests/unit/plugins/modules/test_nmcli.py:2034: AssertionError