fix(modules/gitlab_runner): Fix exception in check mode on new runners #10918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a new runner is added in check mode, the role used to throw an exception. Fix this by returning a valid runner object instead of a boolean. Fixes ansible-collections#8854
ansibullbot
added
bug
1 task
felixfontein
added
check-before-release
felixfontein
approved these changes
Oct 13, 2025
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #10943 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Oct 19, 2025
#10918) * fix(modules/gitlab_runner): Fix exception in check mode on new runners When a new runner is added in check mode, the role used to throw an exception. Fix this by returning a valid runner object instead of a boolean. Fixes #8854 * docs: Add changelog fragment (cherry picked from commit 7e666a9)
Backport to stable-11: 💚 backport PR created✅ Backport PR branch: Backported as #10944 🤖 @patchback |
|
@carlfriedrich thanks for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
Oct 19, 2025
#10918) * fix(modules/gitlab_runner): Fix exception in check mode on new runners When a new runner is added in check mode, the role used to throw an exception. Fix this by returning a valid runner object instead of a boolean. Fixes #8854 * docs: Add changelog fragment (cherry picked from commit 7e666a9)
felixfontein
pushed a commit
that referenced
this pull request
Oct 19, 2025
…Fix exception in check mode on new runners (#10943) fix(modules/gitlab_runner): Fix exception in check mode on new runners (#10918) * fix(modules/gitlab_runner): Fix exception in check mode on new runners When a new runner is added in check mode, the role used to throw an exception. Fix this by returning a valid runner object instead of a boolean. Fixes #8854 * docs: Add changelog fragment (cherry picked from commit 7e666a9) Co-authored-by: carlfriedrich <[email protected]>
felixfontein
pushed a commit
that referenced
this pull request
Oct 19, 2025
…Fix exception in check mode on new runners (#10944) fix(modules/gitlab_runner): Fix exception in check mode on new runners (#10918) * fix(modules/gitlab_runner): Fix exception in check mode on new runners When a new runner is added in check mode, the role used to throw an exception. Fix this by returning a valid runner object instead of a boolean. Fixes #8854 * docs: Add changelog fragment (cherry picked from commit 7e666a9) Co-authored-by: carlfriedrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a new runner is added in check mode, the role used to throw an exception. Fix this by returning a valid runner object instead of a boolean.
Fixes #8854
ISSUE TYPE
COMPONENT NAME
gitlab_runner
ADDITIONAL INFORMATION
For full error description see #8854.