ipa: add environment fallback support for validate_certs

[zjpeterson]

SUMMARY

Add an environment fallback IPA_VALIDATE_CERTS for the validate_certs parameter in the ipa module utils. Currently you can set all connection-related parameters via the environment, except for this one.

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

ipa

ADDITIONAL INFORMATION

[ansibullbot]

cc @Akasurde @Nosmoht @justchris1
click here for bot help

[felixfontein]

Please ignore that sanity error failures, #10755 is adding the necessary ignores.

[felixfontein]

Thanks for your contribution!

I would change the environment variable's name to ANSIBLE_IPA_VALIDATE_CERTS, since we prefer to prefix all environment variables with ANSIBLE_ unless these variables are also interpreted in the same sense by the software that the module manages (which very likely isn't the case here).

[russoz]

Other than the comments by @felixfontein , looks good to me

[felixfontein]

Suggested change

	- If the value is not specified in the task, the value of environment variable E(IPA_VALIDATE_CERTS) is used instead.
	If both the environment variable E(IPA_VALIDATE_CERTS) and the value are not specified in the task, then default value is used.
	- If the value is not specified in the task, the value of environment variable E(ANSIBLE_IPA_VALIDATE_CERTS) is used instead.
	If both the environment variable E(ANSIBLE_IPA_VALIDATE_CERTS) and the value are not specified in the task, then default value is used.

[felixfontein]

Suggested change

	validate_certs=dict(type='bool', default=True, fallback=(env_fallback, ['IPA_VALIDATE_CERTS'])),
	validate_certs=dict(type='bool', default=True, fallback=(env_fallback, ['ANSIBLE_IPA_VALIDATE_CERTS'])),

[zjpeterson]

@felixfontein The other environment vars already start with IPA_ so I just matched it. It would be mismatched to use ANSIBLE_ unless the rest of them change too.

Anecdotally, it has been my experience that module-specific environment variables use a custom prefix matching the module names, such as the use of SN_ in servicenow.itsm, ACI_ in cisco.aci, and MIQ_ for the manageiq modules in this collection.

[felixfontein]

@felixfontein The other environment vars already start with IPA_ so I just matched it.

These have been grandfathered in, since they were added before the ANSIBLE_ prefix rule.

It would be mismatched to use ANSIBLE_ unless the rest of them change too.

True, but that doesn't change that the prefix should be used for new environment variables. (Also it's possible to add additional env variable fallbacks for the existing options that have a prefix.)