Prevent CI to be run for whole collection when modules without integration tests are modified #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integrat on suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). Signed-off-by: Alina Buzachis <[email protected]>
tremble
approved these changes
Mar 14, 2022
ansibullbot
added
bug
Thanks! Opened here #988 |
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
Mar 23, 2022
…module name with missing integration tests. (ansible-collections#986) Prevent CI to be run for whole collection when modules without integration tests are modified Add a fake integration suite including an aliases file listing every module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). Add some of the modules in the aliases files where it makes more sense. SUMMARY ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
alinabuzachis
added a commit
to alinabuzachis/community.aws
that referenced
this pull request
Mar 23, 2022
…module name with missing integration tests. (ansible-collections#986) Prevent CI to be run for whole collection when modules without integration tests are modified Add a fake integration suite including an aliases file listing every module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). Add some of the modules in the aliases files where it makes more sense. SUMMARY ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell <None>
This was referenced Mar 23, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
…module name with missing integration tests. (#986) (#1011) Add a fake integration suite including an aliases file listing every … …module name with missing integration tests. (#986) Prevent CI to be run for whole collection when modules without integration tests are modified Add a fake integration suite including an aliases file listing every module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). Add some of the modules in the aliases files where it makes more sense. SUMMARY ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Woolley <[email protected]>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 24, 2022
…module name with missing integration tests. (#986) (#1010) Add a fake integration suite including an aliases file listing every … …module name with missing integration tests. (#986) Prevent CI to be run for whole collection when modules without integration tests are modified Add a fake integration suite including an aliases file listing every module name with missing integration tests. This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped). Add some of the modules in the aliases files where it makes more sense. SUMMARY ISSUE TYPE Bugfix Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Woolley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a fake integration suite including an aliases file listing every module name with missing integration tests.
This fake suite is necessary for the new CI ansible-test-splitter behaviour. Namely, if one of the modules (listed in the aliases file) without a test suite is modified, the CI is run for the entire collection since the ansible-test-splitter won't find any target match. This fake integration suite helps handle this situation by avoiding running the CI for the whole collection. Furthermore, since the modules listed in the aliases file are marked as disabled, tests are automatically skipped).
Add some of the modules in the aliases files where it makes more sense.
SUMMARY
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION