-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aws_ssm when Powershell uses CLIXML #2080
base: main
Are you sure you want to change the base?
Fix aws_ssm when Powershell uses CLIXML #2080
Conversation
Build failed. ❌ ansible-galaxy-importer FAILURE in 5m 07s (non-voting) |
recheck |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 37s (non-voting) |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 6m 35s (non-voting) |
@tremble I fixed the issue with black, should be ready to be rechecked. |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 25s (non-voting) |
Hi @tremble, anything else I can do for this PR? |
regate |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/82b72a6197ad42bebffe63736d011238 ✔️ ansible-galaxy-importer SUCCESS in 3m 16s (non-voting) |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/8ba12f476c344df280ae7f2fbd8425df ✔️ ansible-galaxy-importer SUCCESS in 3m 18s (non-voting) |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/bb093155316a42a5aec0fe8b68204601 ❌ ansible-galaxy-importer FAILURE in 4m 12s (non-voting) |
|
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/148de36d24f44b7ea38235154ff29725 ❌ ansible-galaxy-importer FAILURE in 4m 52s (non-voting) |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/fb9b7b6c0cbd401ea1c7b78694adf512 ✔️ ansible-galaxy-importer SUCCESS in 3m 51s (non-voting) |
regate |
Build failed (gate pipeline). For information on how to proceed, see https://ansible.softwarefactory-project.io/zuul/buildset/5aa159cb29b6465a9871ee073c02f187 ✔️ ansible-galaxy-importer SUCCESS in 8m 02s (non-voting) |
Hi @markuman @alinabuzachis, is there something I need to change for the build to succeed? |
I'm not sure. Error message is
gateing CI failed, while the check for the PR succeeded. |
recheck |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 24s (non-voting) |
@markuman @alinabuzachis I merged the latest commits from main into this PR, hopefully that fixes the checks? |
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 38s (non-voting) |
@markuman @alinabuzachis I don't follow why the build doesn't succeed. The edits work when I use them on my AWS instance. It seems like something was changed between #2080 (comment) and #2080 (comment), but not the code of this PR. |
This PR looks promising for resolving the CLIXML handling issue in aws_ssm with PowerShell. Our team has been eagerly waiting for this fix as it would significantly streamline our workflows. Thank you for the continuous efforts! Looking forward to seeing this merged soon. If there’s any way we can help or test further, please let us know. |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s (non-voting) |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 20s (non-voting) |
recheck |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 15s (non-voting) |
SUMMARY
This PR adds the code suggested by @PatrickV-code on #1952
ISSUE TYPE
COMPONENT NAME
aws_ssm