Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix untag_resource and tag_resource parameters in eks_nodegroup #1939

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PaulGallon
Copy link

SUMMARY
  • Changes resourceArn to lower camel case as the parameter names are case-sensitive.
  • Removes aws_retry which doesn't appear to exist.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eks_nodegroup

ADDITIONAL INFORMATION

Before resourceArn change:

TASK [Create an EKS node group] ****************************************************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Unknown parameter in input: "ResourceArn", must be one of: resourceArn, tags
fatal: [localhost]: FAILED! => {"boto3_version": "1.26.103", "botocore_version": "1.29.103", "changed": false, "msg": "Unable to set tags for Nodegroup REDACTED.: Parameter validation failed:\nMissing required parameter in input: \"resourceArn\"\nUnknown parameter in input: \"aws_retry\", must be one of: resourceArn, tags\nUnknown parameter in input: \"ResourceArn\", must be one of: resourceArn, tags"}

Before aws_retry change:

TASK [Create an EKS node group] ****************************************************************************************************************************************************************************
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: Unknown parameter in input: "aws_retry", must be one of: resourceArn, tags
fatal: [localhost]: FAILED! => {"boto3_version": "1.26.103", "botocore_version": "1.29.103", "changed": false, "msg": "Unable to set tags for Nodegroup REDACTED.: Parameter validation failed:\nUnknown parameter in input: \"aws_retry\", must be one of: resourceArn, tags"}

After:

TASK [Create an EKS node group] ****************************************************************************************************************************************************************************
ok: [localhost]

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2924c2fb2eb14fabafc87f46b1c6bbaa

ansible-galaxy-importer FAILURE in 5m 29s (non-voting)
✔️ build-ansible-collection SUCCESS in 12m 48s
✔️ ansible-test-splitter SUCCESS in 4m 48s
✔️ integration-community.aws-1 SUCCESS in 26m 54s
Skipped 21 jobs

@PaulGallon
Copy link
Author

@tremble @alinabuzachis Anything I can do to help move this along? I'm not a developer but this small fix works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant