Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag network-interfaces associated with a launch template #2083

Closed
1 task done
shaneikennedy opened this issue Apr 30, 2024 · 0 comments · Fixed by #2164 · May be fixed by #2084
Closed
1 task done

Tag network-interfaces associated with a launch template #2083

shaneikennedy opened this issue Apr 30, 2024 · 0 comments · Fixed by #2164 · May be fixed by #2084
Labels

Comments

@shaneikennedy
Copy link

Summary

Today when you create/update a launch template, the tags are only applied to "instance" and "volume" see here

But a launch template also spins up network-interfaces that are left untagged.

I can't link directly to the doc that im referring to but it's on this page and if you search for "TagSpecifications" you'll see that "network-interfaces" is compatible for tagging with launch templates (not all resources are supported for tagging)

Issue Type

Feature Idea

Component Name

ec2_launch_template

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
alinabuzachis pushed a commit to abikouo/community.aws that referenced this issue Oct 24, 2024
…#2164)

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
alinabuzachis pushed a commit to GomathiselviS/community.aws that referenced this issue Oct 25, 2024
…#2164)

SUMMARY

Depends-On: ansible-collections/amazon.aws#2319

Add some type hint for the module
Use shared code from amazon.aws.plugins.module_utils.ec2
Add the possibility to delete specific version of a launch template
Add support for tagging for launch template resource (Closes ansible-collections#176)
Add the possibility to tag specific resources, not always instance and volume (Closes [ansible-collections#48](ansible-collections#48, Closes ansible-collections#2083)
Support EBS Throughput (Closes ansible-collections#1944)
Fix issue occurring when launch template contains more than 200 versions (Closes ansible-collections#2131)


ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_launch_template

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants