Added crlf/lf option to telnet #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this would fix #446 as well. I hit the same issue and fixed it more or less the same way. |
Qalthos
added
needs_info
Qalthos
requested changes
Nov 21, 2022
There was a problem hiding this comment.
Can you please add a changelog fragment to your PR? Thanks!
Qalthos
added
the
needs_info
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
michaelpsomiadis
force-pushed
the
main
branch
2 times, most recently
from
9746099 to
07ef0c5
Compare
|
Apologies, better late than never? decided to rebase and re-implement the changes because the latest version of the telnet module had been changed a little bit. Let me know if I've missed anything. |
Qalthos
added
feature
Qalthos
approved these changes
Sep 5, 2023
for more information, see https://pre-commit.ci
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 18, 2023
v8.4.0 Major Changes ------------- fortinet.fortios - Improve the document for adding notes and examples in Q&A for modules using Integer number as the mkey. Minor Changes ------------- amazon.aws - cloudformation - Add support for ``disable_rollback`` to update stack operation (ansible-collections/amazon.aws#1681). - ec2_key - add support for new parameter ``file_name`` to save private key in when new key is created by AWS. When this option is provided the generated private key will be removed from the module return (ansible-collections/amazon.aws#1704). ansible.netcommon - Add a new cliconf plugin ``default`` that can be used when no cliconf plugin is found for a given network_os. This plugin only supports ``get()``. (ansible-collections/ansible.netcommon#569) - httpapi - Add additional option ``ca_path``, ``client_cert``, ``client_key``, and ``http_agent`` that are available in open_url but not to httpapi. (ansible-collections/ansible.netcommon#528) - telnet - add crlf option to send CRLF instead of just LF (ansible-collections/ansible.netcommon#440). ansible.utils - Add ipcut filter plugin.(ansible-collections/ansible.utils#251) - Add ipv6form filter plugin.(ansible-collections/ansible.utils#230) arista.eos - Add support for overridden operation in bgp_global resource module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds option to send a CLRF instead of a LF when talking to a device via telnet.
ISSUE TYPE
COMPONENT NAME
telnet
ADDITIONAL INFORMATION
When attempting to use this plugin to send commands to a service that uses telnet I noticed that it required CLRF to "submit" the input (in this case being the username prompt). After just changing the strings to be CLRF I decided to add the functionality just incase someone else tries to use it in the future and hits this issue.
I've tested the code with the play that I was attempting to use it with success and original functionality should stay the same to not break existing plays.
Please let me know if you'd like me to make any changes. Thanks.