Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #881/289e9870 backport][stable-4] Module naming guidelines #896

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jun 24, 2022

This is a backport of PR #881 as merged into main (289e987).

SUMMARY

Originally discussed in #610

Here's an initial attempt at some module naming (and module scoping) guidelines.

Assuming we adopt this, I recommend is that:

  • we can do the renames as part of 5.0.0, but this isn't a must and wouldn't be considered a blocker to 5.0.0 unless otherwise agreed.
  • any modules moving from community.aws to amazon.aws would be renamed if appropriate as part of the move.
  • we do not specify a deprecation date at this time, but leave a comment in the redirect that any deprecation cycle should not start before 2024-09-01 (to avoid potential migration fatigue issues),
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/dev_guidelines.rst

ADDITIONAL INFORMATION

fixes: #610

@patchback patchback bot mentioned this pull request Jun 24, 2022
@github-actions
Copy link

github-actions bot commented Jun 24, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 05s
✔️ build-ansible-collection SUCCESS in 5m 06s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 38s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 22s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 08s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 08s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 28s

Module naming guidelines

SUMMARY
Originally discussed in #610
Here's an initial attempt at some module naming (and module scoping) guidelines.
Assuming we adopt this, I recommend is that:

we can do the renames as part of 5.0.0, but this isn't a must and wouldn't be considered a blocker to 5.0.0 unless otherwise agreed.
any modules moving from community.aws to amazon.aws would be renamed if appropriate as part of the move.
we do not specify a deprecation date at this time, but leave a comment in the redirect that any deprecation cycle should not start before 2024-09-01 (to avoid potential migration fatigue issues),

ISSUE TYPE

Docs Pull Request

COMPONENT NAME
docs/docsite/rst/dev_guidelines.rst
ADDITIONAL INFORMATION
fixes: #610

Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Reviewed-by: Markus Bergholz <[email protected]>
(cherry picked from commit 289e987)
@tremble tremble force-pushed the patchback/backports/stable-4/289e98702ef8258935167d5017b3ac040d93f30b/pr-881 branch from d5e3fec to 785384b Compare June 24, 2022 08:52
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 57s
✔️ build-ansible-collection SUCCESS in 4m 49s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 13s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 51s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 33s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 04s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 02s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 24, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 27s
✔️ build-ansible-collection SUCCESS in 5m 48s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 03s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 03s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 16s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 10s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 02s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 43e2c3e into stable-4 Jun 24, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-4/289e98702ef8258935167d5017b3ac040d93f30b/pr-881 branch June 24, 2022 09:36
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 22, 2022
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@017081c
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 23, 2022
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@017081c
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <[email protected]>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs mergeit Merge the PR (SoftwareFactory) needs_triage new_contributor Help guide this first time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants