-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #881/289e9870 backport][stable-4] Module naming guidelines #896
[PR #881/289e9870 backport][stable-4] Module naming guidelines #896
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 05s |
Module naming guidelines SUMMARY Originally discussed in #610 Here's an initial attempt at some module naming (and module scoping) guidelines. Assuming we adopt this, I recommend is that: we can do the renames as part of 5.0.0, but this isn't a must and wouldn't be considered a blocker to 5.0.0 unless otherwise agreed. any modules moving from community.aws to amazon.aws would be renamed if appropriate as part of the move. we do not specify a deprecation date at this time, but leave a comment in the redirect that any deprecation cycle should not start before 2024-09-01 (to avoid potential migration fatigue issues), ISSUE TYPE Docs Pull Request COMPONENT NAME docs/docsite/rst/dev_guidelines.rst ADDITIONAL INFORMATION fixes: #610 Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> Reviewed-by: Markus Bergholz <[email protected]> (cherry picked from commit 289e987)
d5e3fec
to
785384b
Compare
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 57s |
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 27s |
Cleanup unused imports (ansible-collections#852 / ansible-collections#892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@017081c
Cleanup unused imports (ansible-collections#852 / ansible-collections#892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@017081c
Cleanup unused imports (ansible-collections#852 / ansible-collections#892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
Cleanup unused imports (ansible-collections#852 / ansible-collections#892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
Cleanup unused imports (ansible-collections#852 / ansible-collections#892) Let's try once more... SUMMARY My local tests are flagging that we've picked up some unused imports again. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_glue_job cloudfront_info rds_option_group_info ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Alina Buzachis <None>
This is a backport of PR #881 as merged into main (289e987).
SUMMARY
Originally discussed in #610
Here's an initial attempt at some module naming (and module scoping) guidelines.
Assuming we adopt this, I recommend is that:
ISSUE TYPE
COMPONENT NAME
docs/docsite/rst/dev_guidelines.rst
ADDITIONAL INFORMATION
fixes: #610