Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing npm lint script #624

Merged
merged 2 commits into from
Jan 21, 2019

Conversation

rappestad
Copy link

I cloned this repository to work on #600, but got the error below. The change in this pull request lets me run the test suite via Docker. With this out of the way, I could not reproduce the problem described in #600; that test passed with node 8 as well as node 10.

My developer console:

> docker build -t monument .
...
> docker run monument

Container output:

2018-10-03T20:34:55.795062900Z 
> [email protected] test /src
> npm run lint && nyc ava -s *.test.js utils/**/*.test.js web-sockets/**/*.test.js security/**/*.test.js routes/**/*.test.js
2018-10-03T20:34:55.795113500Z 
2018-10-03T20:34:56.009310600Z 
> [email protected] lint /src
> bin/lint.js
2018-10-03T20:34:56.009360500Z 
/usr/bin/env: node : No such file or directory
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! [email protected] lint: `bin/lint.js`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the [email protected] lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
2018-10-03T20:34:56.033124500Z 
npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2018-10-03T20_34_56_027Z-debug.log
npm ERR! Test failed.  See above for more details.

fix npm run lint failing with message '/usr/bin/env: node : No such file or directory' when running docker
@coveralls
Copy link

coveralls commented Oct 3, 2018

Coverage Status

Coverage remained the same at 98.218% when pulling e876816 on rappestad:master into 9cc92f3 on ansble:master.

@designfrontier designfrontier changed the base branch from master to Paris–Brussels-5.x.x January 21, 2019 05:31
@designfrontier designfrontier merged commit 80b154c into ansble:Paris–Brussels-5.x.x Jan 21, 2019
@designfrontier
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants