Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial refactor of statistics code #112

Merged
merged 28 commits into from
Jun 8, 2023
Merged

Partial refactor of statistics code #112

merged 28 commits into from
Jun 8, 2023

Conversation

anorthall
Copy link
Owner

A complete refactor of trip statistics, moving the functionality into its own Django application and refactoring all code to be reusable and testable.

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 99.70% and project coverage change: +3.69 🎉

Comparison is base (ebb13d3) 91.40% compared to head (ff0200f) 95.09%.

❗ Current head ff0200f differs from pull request most recent head ea00c79. Consider uploading reports for the commit ea00c79 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   91.40%   95.09%   +3.69%     
==========================================
  Files          84       94      +10     
  Lines        3758     4040     +282     
==========================================
+ Hits         3435     3842     +407     
+ Misses        323      198     -125     
Impacted Files Coverage Δ
app/logger/admin.py 100.00% <ø> (+3.33%) ⬆️
app/logger/views.py 91.63% <95.83%> (+0.28%) ⬆️
app/core/tests/test_news_and_faqs.py 100.00% <100.00%> (ø)
app/core/tests/test_pages_load.py 100.00% <100.00%> (ø)
app/core/utils.py 100.00% <100.00%> (ø)
app/logger/tests/test_social_functionality.py 100.00% <100.00%> (ø)
app/logger/tests/test_trip_model.py 100.00% <100.00%> (ø)
app/stats/apps.py 100.00% <100.00%> (ø)
app/stats/statistics/__init__.py 100.00% <100.00%> (ø)
app/stats/statistics/averages.py 100.00% <100.00%> (ø)
... and 10 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anorthall anorthall marked this pull request as ready for review June 8, 2023 18:28
@anorthall anorthall changed the title Refactor of statistics (closes #40) Partial refactor of statistics code Jun 8, 2023
@anorthall anorthall merged commit ca20821 into main Jun 8, 2023
3 checks passed
@anorthall anorthall deleted the statistics branch June 8, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant