Refactor of statistics code (#40)

anorthall · Jun 20, 2023 · 3b6867d · 3b6867d
1 parent 36fc9a0
commit 3b6867d
Show file tree

Hide file tree

Showing 23 changed files with 487 additions and 1,306 deletions.
diff --git a/app/logger/charts.py b/app/logger/charts.py
diff --git a/app/logger/charts_urls.py b/app/logger/charts_urls.py
diff --git a/app/logger/mixins.py b/app/logger/mixins.py
@@ -42,6 +42,7 @@ def get_context_data(self, *args, **kwargs):
         return context
 
 
+# noinspection PyAttributeOutsideInit
 class ViewableObjectDetailView(DetailView):
     """A DetailView that considers permissions for objects like Trip and TripReport"""
 
@@ -59,6 +60,7 @@ def get(self, request, *args, **kwargs):
         return self.render_to_response(context)
 
 
+# noinspection PyAttributeOutsideInit
 class ReportObjectMixin:
     """Mixin to get report objects from a Trip UUID"""
 
@@ -84,7 +86,8 @@ def __init__(self, *args, **kwargs):
 
         instance = kwargs.get("instance", None)
         if not instance:
-            return super().__init__(*args, **kwargs)
+            super().__init__(*args, **kwargs)
+            return
 
         distance_fields = [
             "horizontal_dist",